RESOLVED FIXED 53346
[chromium] remove --use-test-shell from NRWT 
https://bugs.webkit.org/show_bug.cgi?id=53346
Summary [chromium] remove --use-test-shell from NRWT
Tony Chang
Reported 2011-01-28 16:02:35 PST
[chromium] remove --use-test-shell from NRWT
Attachments
Patch (15.11 KB, patch)
2011-01-28 16:03 PST, Tony Chang 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-01-28 16:03:56 PST
Created attachment 80518 [details] Patch
Dirk Pranke
Comment 2 2011-01-28 16:38:37 PST
The change looks fine to me. However, whenever I have tried to run multiple DRTs in parallel, I run into lots of instability (at least on the mac - see bugs 50704 and 50709). Does test_shell no longer work at all? If so, I can live with removing it, but if test_shell still works at least a bit, I would like to keep this switch around until we fix the concurrency issues w/ DRT.
Tony Chang
Comment 3 2011-01-28 16:58:24 PST
Ah right, I forgot about that. Yeah, let's fix bug 50709 first.
Eric Seidel (no email)
Comment 4 2011-01-30 04:07:01 PST
Comment on attachment 80518 [details] Patch rs=me.
Tony Chang
Comment 5 2011-02-02 13:23:37 PST
Committed r77410: <http://trac.webkit.org/changeset/77410>
WebKit Review Bot
Comment 6 2011-02-02 15:46:54 PST
http://trac.webkit.org/changeset/77410 might have broken GTK Linux 32-bit Release The following tests are not passing: editing/selection/find-yensign-and-backslash.html http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html
Note You need to log in before you can comment on or make changes to this bug.