Bug 53346 - [chromium] remove --use-test-shell from NRWT
Summary: [chromium] remove --use-test-shell from NRWT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-28 16:02 PST by Tony Chang
Modified: 2011-02-02 15:46 PST (History)
6 users (show)

See Also:


Attachments
Patch (15.11 KB, patch)
2011-01-28 16:03 PST, Tony Chang
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-01-28 16:02:35 PST
[chromium] remove --use-test-shell from NRWT
Comment 1 Tony Chang 2011-01-28 16:03:56 PST
Created attachment 80518 [details]
Patch
Comment 2 Dirk Pranke 2011-01-28 16:38:37 PST
The change looks fine to me.

However, whenever I have tried to run multiple DRTs in parallel, I run into lots of instability (at least on the mac - see bugs 50704 and 50709). Does test_shell no longer work at all? If so, I can live with removing it, but if test_shell still works at least a bit, I would like to keep this switch around until we fix the concurrency issues w/ DRT.
Comment 3 Tony Chang 2011-01-28 16:58:24 PST
Ah right, I forgot about that.  Yeah, let's fix bug 50709 first.
Comment 4 Eric Seidel (no email) 2011-01-30 04:07:01 PST
Comment on attachment 80518 [details]
Patch

rs=me.
Comment 5 Tony Chang 2011-02-02 13:23:37 PST
Committed r77410: <http://trac.webkit.org/changeset/77410>
Comment 6 WebKit Review Bot 2011-02-02 15:46:54 PST
http://trac.webkit.org/changeset/77410 might have broken GTK Linux 32-bit Release
The following tests are not passing:
editing/selection/find-yensign-and-backslash.html
http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html