Bug 53328 - Web Inspector: copy HAR to clipboard instead of saving blob on export.
Summary: Web Inspector: copy HAR to clipboard instead of saving blob on export.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-28 13:27 PST by Pavel Feldman
Modified: 2011-01-31 16:15 PST (History)
13 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2011-01-28 13:30 PST, Pavel Feldman 		yurys: review+
pfeldman: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-01-28 13:27:24 PST 
Saving blob is not user friendly: ends up in random location, file has random name. We should wait for FileSaver API to land and use it. Until then, I am suggesting to copy to clipboard instead.
Comment 1 Pavel Feldman 2011-01-28 13:30:11 PST 
Created attachment 80490 [details]
Patch
Comment 2 Pavel Feldman 2011-01-31 07:19:18 PST 
Committed r77128: <http://trac.webkit.org/changeset/77128>
Comment 3 Eric Seidel (no email) 2011-01-31 15:56:48 PST 
One of the commit-queue nodes seems to be hung in a loop trying to land this.  Trying to figure out why now.
Comment 4 Eric Seidel (no email) 2011-01-31 16:00:37 PST 
http://queues.webkit.org/queue-status/commit-queue/bots/eseidel-cq-sf was the bot which got stuck for the record.


Retry
webkitpy.common.net.statusserver: [INFO] Releasing work item 80490 from commit-queue
Unable to process work item.
Fetching: https://bugs.webkit.org/attachment.cgi?id=80490&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=53328&ctype=xml
Processing patch
Adding [] to the CC list for bug 53328
Fetching: https://bugs.webkit.org/attachment.cgi?id=80490&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=53328&ctype=xml
Retry
webkitpy.common.net.statusserver: [INFO] Releasing work item 80490 from commit-queue
Unable to process work item.
Fetching: https://bugs.webkit.org/attachment.cgi?id=80490&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=53328&ctype=xml
Processing patch
Adding [] to the CC list for bug 53328
Fetching: https://bugs.webkit.org/attachment.cgi?id=80490&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=53328&ctype=xml
Retry
webkitpy.common.net.statusserver: [INFO] Releasing work item 80490 from commit-queue
Unable to process work item.

Was the retry loop.  Investigating.
Comment 5 Eric Seidel (no email) 2011-01-31 16:05:04 PST 
Yeah, the commit-queue seems to have no way of clearing out patches from its queue.  Interesting.  We have other scripts for this, but they're not currently run automatically.
Comment 6 Eric Seidel (no email) 2011-01-31 16:05:45 PST 
Running webkit-patch clean-pending-commit manually to clean out this (and possibly other) patches which got stuck in the queue.
Comment 7 Eric Seidel (no email) 2011-01-31 16:12:20 PST 
Actually, the feeder queue should be removing this automatically once it's closed.

I suspect the feeder queue may be down.  The style-queue went down 12 hours ago. :(
Comment 8 Eric Seidel (no email) 2011-01-31 16:15:49 PST 
Yes, the feeder queue must have been down.  I started one locally and this bug was (correctly) removed from the queue.