Bug 53317 - Space not necessary for undefined feature
Summary: Space not necessary for undefined feature
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-28 11:49 PST by Pratik Solanki
Modified: 2011-01-28 12:36 PST (History)
2 users (show)

See Also:

Attachments
Patch (30.50 KB, patch)
2011-01-28 11:57 PST, Pratik Solanki 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2011-01-28 11:49:30 PST 
Following line in build-webkit defines feature as a space (" "). This can cause build failures in future.

408         return $feature . "=" . ($isEnabled ? $feature : " ");

We should remove the space.
Comment 1 Pratik Solanki 2011-01-28 11:57:53 PST 
Created attachment 80472 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2011-01-28 12:03:45 PST 
Comment on attachment 80472 [details]
Patch

r=me
Comment 3 Pratik Solanki 2011-01-28 12:28:28 PST 
Committed r76971: <http://trac.webkit.org/changeset/76971>
Comment 4 Pratik Solanki 2011-01-28 12:36:49 PST 
Accidental .swp file check removed in http://trac.webkit.org/changeset/76973