Bug 53314 - REGRESSION(r76951): Appearance of media controls changed slightly on Qt/Chromium ports
Summary: REGRESSION(r76951): Appearance of media controls changed slightly on Qt/Chrom...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on: 53122 53674
Blocks: 53020
  Show dependency tree / graph
 
Reported: 2011-01-28 11:03 PST by Dimitri Glazkov (Google)
Modified: 2011-02-04 13:43 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2011-01-31 15:49 PST, Dimitri Glazkov (Google) 		jamesr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-01-28 11:03:03 PST 
This is due to the fact that UA stylesheets are now matched inside of the shadow DOM subtree. The fix is to tweak the stylesheets to get the back to the same shape.

Qt test: 
  media/controls-without-preload.html -> failed

Chromium tests:
  media/controls-strict.html = IMAGE+TEXT
  media/video-zoom-controls.html = IMAGE+TEXT
Comment 1 WebKit Review Bot 2011-01-28 12:18:15 PST 
http://trac.webkit.org/changeset/76957 might have broken Leopard Intel Release (Tests)
Comment 2 Dimitri Glazkov (Google) 2011-01-31 15:49:40 PST 
Created attachment 80692 [details]
Patch
Comment 3 James Robinson 2011-01-31 15:52:05 PST 
Comment on attachment 80692 [details]
Patch

ok
Comment 4 Dimitri Glazkov (Google) 2011-01-31 15:54:58 PST 
Committed r77171: <http://trac.webkit.org/changeset/77171>
Comment 5 Dimitri Glazkov (Google) 2011-02-03 09:06:43 PST 
*** Bug 53674 has been marked as a duplicate of this bug. ***
Comment 6 Dimitri Glazkov (Google) 2011-02-03 09:07:16 PST 
Qt still isn't fixed.