Bug 53309 - Web Inspector: "Clear CPU profiles" button title is too specific having multiple profile types.
Summary: Web Inspector: "Clear CPU profiles" button title is too specific having multi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-28 09:56 PST by Mikhail Naganov
Modified: 2011-01-31 02:45 PST (History)
10 users (show)

See Also:


Attachments
patch (648 bytes, patch)
2011-01-28 10:01 PST, Mikhail Naganov
yurys: review-
mnaganov: commit-queue-
Details | Formatted Diff | Diff
now full diff (1.94 KB, patch)
2011-01-28 10:23 PST, Mikhail Naganov
yurys: review+
mnaganov: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2011-01-28 09:56:27 PST
As besides CPU profiles there can be heap profiles, the name of the button: "Clear CPU profiles" is misleading. My proposal is to change the text to "Clear all profiles".
Comment 1 Mikhail Naganov 2011-01-28 10:01:07 PST
Created attachment 80461 [details]
patch
Comment 2 Yury Semikhatsky 2011-01-28 10:22:40 PST
Comment on attachment 80461 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80461&action=review

> Source/WebCore/ChangeLog:10
> +        * inspector/front-end/ProfilesPanel.js:

You seem to have missed the changes.
Comment 3 Mikhail Naganov 2011-01-28 10:23:41 PST
Created attachment 80463 [details]
now full diff
Comment 4 Mikhail Naganov 2011-01-31 02:45:29 PST
Manually committed http://trac.webkit.org/changeset/77116


2011-01-31  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: Change button title from "Clear CPU profiles" to "Clear all profiles".

        https://bugs.webkit.org/show_bug.cgi?id=53309

        * English.lproj/localizedStrings.js:
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel):