Bug 53304 - [Windows 7 Release Tests] editing/pasteboard/get-data-text-plain-paste.html, editing/pasteboard/onpaste-text-html.html, fast/events/drag-and-drop-dataTransfer-types-nocrash.html, and fast/events/ondrop-text-html.html failing since r76824
Summary: [Windows 7 Release Tests] editing/pasteboard/get-data-text-plain-paste.html, ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Windows 7
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords: LayoutTestFailure, PlatformOnly, Regression
Depends on:
Blocks:
 
Reported: 2011-01-28 08:32 PST by Jessie Berlin
Modified: 2011-01-28 11:47 PST (History)
5 users (show)

See Also:

Attachments
Patch (7.24 KB, patch)
2011-01-28 11:29 PST, Enrica Casucci 		aroben: review+
aroben: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Jessie Berlin 2011-01-28 09:03:25 PST 
Failing expected results committed for Windows in r76948:
http://trac.webkit.org/changeset/76948
Comment 2 Enrica Casucci 2011-01-28 11:29:49 PST 
Created attachment 80467 [details]
Patch

Fix for a silly mistake.
Comment 3 WebKit Review Bot 2011-01-28 11:32:00 PST 
Attachment 80467 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

LayoutTests/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 10 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Adam Roben (:aroben) 2011-01-28 11:35:35 PST 
Comment on attachment 80467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80467&action=review

> LayoutTests/ChangeLog:13
> +        * platform/win/editing/pasteboard/get-data-text-plain-paste-expected.txt:
> +        * platform/win/editing/pasteboard/onpaste-text-html-expected.txt:
> +        * platform/win/fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt:
> +        * platform/win/fast/events/ondrop-text-html-expected.txt:

Instead of modifying these files, you should just delete them. That way we'll use the cross-platform expected results.
Comment 5 Enrica Casucci 2011-01-28 11:47:15 PST 
http://trac.webkit.org/changeset/76961