Bug 53304 – [Windows 7 Release Tests] editing/pasteboard/get-data-text-plain-paste.html, editing/pasteboard/onpaste-text-html.html, fast/events/drag-and-drop-dataTransfer-types-nocrash.html, and fast/events/ondrop-text-html.html failing since r76824

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Jessie Berlin]

http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r76821%20(8715)/results.html
http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r76824%20(8716)/results.html

I will check in the failing results.

[Jessie Berlin]

Failing expected results committed for Windows in r76948:
http://trac.webkit.org/changeset/76948

[Enrica Casucci]

Created attachment 80467 [details]
Patch

Fix for a silly mistake.

[WebKit Review Bot]

Attachment 80467 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

LayoutTests/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 10 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Roben (:aroben)]

Comment on attachment 80467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80467&action=review

> LayoutTests/ChangeLog:13
> +        * platform/win/editing/pasteboard/get-data-text-plain-paste-expected.txt:
> +        * platform/win/editing/pasteboard/onpaste-text-html-expected.txt:
> +        * platform/win/fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt:
> +        * platform/win/fast/events/ondrop-text-html-expected.txt:

Instead of modifying these files, you should just delete them. That way we'll use the cross-platform expected results.

[Enrica Casucci]

http://trac.webkit.org/changeset/76961