Bug 53303 - Web Inspector: allow remote debugging with front-end served from the cloud.
Summary: Web Inspector: allow remote debugging with front-end served from the cloud.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-28 08:30 PST by Pavel Feldman
Modified: 2011-01-28 08:57 PST (History)
10 users (show)

See Also:

Attachments
[PATCH] Proposed change. (1.70 KB, patch)
2011-01-28 08:36 PST, Pavel Feldman 		yurys: review-
Details | Formatted Diff | Diff
[PATCH] A better patch. (1.62 KB, patch)
2011-01-28 08:41 PST, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-01-28 08:30:31 PST 
Sometimes we don't want to serve front-end from the browser. Make it possible.

Patch to follow.
Comment 1 Pavel Feldman 2011-01-28 08:36:32 PST 
Created attachment 80453 [details]
[PATCH] Proposed change.
Comment 2 Yury Semikhatsky 2011-01-28 08:40:17 PST 
Comment on attachment 80453 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=80453&action=review

> Source/WebCore/inspector/front-end/inspector.js:482
> +    if (WebInspector.socket) {

Did you mean !WebInspector.socket
Comment 3 Pavel Feldman 2011-01-28 08:41:05 PST 
Created attachment 80454 [details]
[PATCH] A better patch.
Comment 4 Yury Semikhatsky 2011-01-28 08:44:47 PST 
Comment on attachment 80454 [details]
[PATCH] A better patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=80454&action=review

> Source/WebCore/inspector/front-end/inspector.js:479
> +    else if ("page" in WebInspector.queryParamsObject)

Could you factor out if ("page" in WebInspector.queryParamsObject) in an outer if block?
Comment 5 Pavel Feldman 2011-01-28 08:57:08 PST 
Ok, ok, no hurry anymore. Landed beautified.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/inspector/front-end/inspector.js
Committed r76947