Bug 53289 - DOM: Move DocumentOrderedMap from Document into separate files
Summary: DOM: Move DocumentOrderedMap from Document into separate files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Roland Steiner
URL:
Keywords:
Depends on:
Blocks: 52963
  Show dependency tree / graph
 
Reported: 2011-01-28 01:05 PST by Roland Steiner
Modified: 2011-02-01 05:23 PST (History)
5 users (show)

See Also:

Attachments
Patch (23.19 KB, patch)
2011-01-28 02:24 PST, Roland Steiner 		no flags Details | Formatted Diff | Diff
Patch, try again (25.44 KB, patch)
2011-01-30 21:45 PST, Roland Steiner 		no flags Details | Formatted Diff | Diff
Patch, try de third (26.71 KB, patch)
2011-01-31 01:02 PST, Roland Steiner 		dglazkov: review+
dglazkov: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2011-01-28 01:05:58 PST 
DocumentOrderedMap currently is a nested class inside Document.

To cut down on the size of Document.h/.cpp, as well as allow further refactoring, esp. for shadow DOM, it would be better if this was made a separate class and moved into its own files.
Comment 1 Roland Steiner 2011-01-28 02:24:28 PST 
Created attachment 80432 [details]
Patch
Comment 2 Build Bot 2011-01-28 03:19:08 PST 
Attachment 80432 [details] did not build on win:
Build output: http://queues.webkit.org/results/7560379
Comment 3 Early Warning System Bot 2011-01-28 03:23:42 PST 
Attachment 80432 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7657049
Comment 4 Dimitri Glazkov (Google) 2011-01-28 08:50:42 PST 
Comment on attachment 80432 [details]
Patch

This is great! Please update all build systems to ensure no bot breakages.
Comment 5 Roland Steiner 2011-01-30 21:45:10 PST 
Created attachment 80617 [details]
Patch, try again
Comment 6 Build Bot 2011-01-30 22:43:56 PST 
Attachment 80617 [details] did not build on win:
Build output: http://queues.webkit.org/results/7680166
Comment 7 Early Warning System Bot 2011-01-31 00:15:09 PST 
Attachment 80617 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7567944
Comment 8 Roland Steiner 2011-01-31 01:02:26 PST 
Created attachment 80623 [details]
Patch, try de third
Comment 9 Roland Steiner 2011-01-31 02:08:16 PST 
Hmmm... any idea what issues 'gtk' and 'mac' have patching the .vcproj file? 'win' seems to like it... @_@?
Comment 10 Dimitri Glazkov (Google) 2011-01-31 08:54:18 PST 
Comment on attachment 80623 [details]
Patch, try de third

View in context: https://bugs.webkit.org/attachment.cgi?id=80623&action=review

Changes to vcproj suck. I don't know why, but I get purples on them too. But your project changes look good, except for android. Let's see if this works.

> Source/WebCore/ChangeLog:13
> +        * GNUMakefile.am:

I think you're going to break Android build.
Comment 11 Roland Steiner 2011-02-01 01:32:44 PST 
Reverted r77229 for reason:

revert mysterious build breakage

Committed r77231: <http://trac.webkit.org/changeset/77231>
Comment 12 Roland Steiner 2011-02-01 05:23:09 PST 
committed in r77239, with additional entries in Android.mk and CMakeLists.txt, so as to hopefully not-break Android and EFL.