Bug 53284 - Build fix for Mac Intel Debug after r76916
Summary: Build fix for Mac Intel Debug after r76916
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-27 23:11 PST by Laszlo Gombos
Modified: 2011-01-28 00:05 PST (History)
2 users (show)

See Also:


Attachments
buildfix (1.09 KB, patch)
2011-01-27 23:14 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff
2nd try (1.12 KB, patch)
2011-01-27 23:42 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2011-01-27 23:11:52 PST
Macro redefinition

In file included from /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/WebKitBuild/Debug/DerivedSources/WebKit2/WebPageMessages.h:25,
                 from /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Source/WebKit2/UIProcess/cf/WebPageProxyCF.cpp:33:
/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Source/WebKit2/config.h:38:1: error: "EXTERN_C_BEGIN" redefined

/usr/include/c++/4.2.1/i686-apple-darwin10/x86_64/bits/c++config.h:320:99: error: this is the location of the previous definition
Comment 1 Laszlo Gombos 2011-01-27 23:14:43 PST
Created attachment 80422 [details]
buildfix
Comment 2 Laszlo Gombos 2011-01-27 23:42:21 PST
Created attachment 80423 [details]
2nd try
Comment 3 WebKit Review Bot 2011-01-27 23:43:41 PST
Attachment 80423 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/config.h:38:  #ifndef header guard has wrong style, please use: WTF_config_h  [build/header_guard] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Maciej Stachowiak 2011-01-27 23:44:42 PST
Comment on attachment 80423 [details]
2nd try

r=me
Comment 5 Build Bot 2011-01-27 23:48:19 PST
Attachment 80422 [details] did not build on win:
Build output: http://queues.webkit.org/results/7640137
Comment 6 Laszlo Gombos 2011-01-28 00:04:54 PST
Comment on attachment 80423 [details]
2nd try

Landed as http://trac.webkit.org/changeset/76922.

Clearing flags.