Bug 53278 - WebKit2: the cookies used by the WebKit2 Web Process should not go in a top-level directory
Summary: WebKit2: the cookies used by the WebKit2 Web Process should not go in a top-l...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Windows 7
: P2 Normal
Assignee: Jessie Berlin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-01-27 18:41 PST by Jessie Berlin
Modified: 2011-03-25 09:32 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.55 KB, patch)
2011-01-27 18:49 PST, Jessie Berlin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2011-01-27 18:41:16 PST 
<rdar://problem/8927925>
Comment 1 Jessie Berlin 2011-01-27 18:49:56 PST 
Created attachment 80399 [details]
Patch
Comment 2 Steve Falkenburg 2011-01-28 09:20:22 PST 
Comment on attachment 80399 [details]
Patch

Seems strange that we use 522+ in this plist, and also in WebKit's Info.plist. JavaScriptCore uses 530, which is also out of date. On Windows, this version doesn't matter - we should probably just remove it from the string in these Windows Info.plist files (starting with this one).
Comment 3 Jessie Berlin 2011-01-28 13:10:48 PST 
Holding off on committing as there is some discussion as to whether this is the right approach (maybe we can still figure out a way to share the cookies)
Comment 4 Jessie Berlin 2011-01-31 10:55:04 PST 
Removed the following lines:

	<key>CFBundleShortVersionString</key>
	<string>522+</string>
	<key>CFBundleVersion</key>
	<string>522+</string>

Also changed the copyright date to be just 2011, since this file and bundle is new.
Comment 5 Jessie Berlin 2011-01-31 11:27:07 PST 
Comment on attachment 80399 [details]
Patch

Committed in r77147
http://trac.webkit.org/changeset/77147
Comment 6 Jessie Berlin 2011-03-25 09:32:24 PDT 
I appear to have forgotten to mark this as fixed. Doing so now.