Bug 53277 - Add basic rubber banding support
Summary: Add basic rubber banding support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.6
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-27 18:16 PST by Sam Weinig
Modified: 2011-01-28 12:18 PST (History)
3 users (show)

See Also:


Attachments
Patch (31.64 KB, patch)
2011-01-27 18:18 PST, Sam Weinig
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-01-27 18:16:17 PST
Add basic rubber bandings support.
Comment 1 Sam Weinig 2011-01-27 18:18:07 PST
Created attachment 80393 [details]
Patch
Comment 2 Maciej Stachowiak 2011-01-27 18:39:54 PST
Comment on attachment 80393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80393&action=review

r=me with minor comments.

> Source/WebCore/ChangeLog:5
> +        Add basic rubber bandings support

s/bandings/banding/

> Source/WebCore/page/EventHandler.cpp:2047
> +    // that if a frame gets a gesture begin gesture, it gets the corrisponding

s/corrisponding/corresponding/

> Source/WebCore/platform/mac/ScrollAnimatorMac.h:44
> +#define SUPPORT_RUBBER_BANDING 1

This should probably be an ENABLE macro.
Comment 3 Sam Weinig 2011-01-28 11:06:06 PST
Landed in r76956.
Comment 4 WebKit Review Bot 2011-01-28 12:18:10 PST
http://trac.webkit.org/changeset/76956 might have broken Leopard Intel Release (Tests)