Bug 53273 - Rename Typed Array slice() to subset()
Summary: Rename Typed Array slice() to subset()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks: 53618
  Show dependency tree / graph
 
Reported: 2011-01-27 17:28 PST by Kenneth Russell
Modified: 2011-02-02 12:32 PST (History)
3 users (show)

See Also:

Attachments
Patch (49.20 KB, patch)
2011-01-27 17:35 PST, Kenneth Russell 		jamesr: review+
kbr: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2011-01-27 17:28:31 PST 
The WebGL working group resolved at the most recent face-to-face to rename the slice() method on Typed Arrays to subset() to avoid collisions with ECMAScript arrays' slice() method, because Typed Arrays' slices have slightly different semantics (they reference the same underlying data instead of copying it). The WebKit implementation needs to be changed to track this and the conformance tests updated.
Comment 1 Kenneth Russell 2011-01-27 17:35:39 PST 
Created attachment 80385 [details]
Patch
Comment 2 Zhenyao Mo 2011-01-27 17:53:19 PST 
Looks good.
Comment 3 James Robinson 2011-01-27 18:04:07 PST 
Comment on attachment 80385 [details]
Patch

R=me. I hope it compiles everywhere :)
Comment 4 Kenneth Russell 2011-01-27 18:15:45 PST 
Committed r76892: <http://trac.webkit.org/changeset/76892>