Bug 53264 – [GTK] Implement device element dialog and stream device probing

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKitGTK

[Adam Bergkvist]

Some GTK specific parts are needed to use the device element (device selector dialog and stream device probing).

[Adam Bergkvist]

Created attachment 80414 [details]
Proposed patch

Proposed GTK implementation of the platform specific parts of the device element (see https://bugs.webkit.org/show_bug.cgi?id=47264).

[Philippe Normand]

Comment on attachment 80414 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80414&action=review

I haven't done a full review of this patch, only spotted this small issue

> Source/WebCore/platform/device/gstreamer/StreamDeviceManagerPrivateGStreamer.cpp:79
> +    const GParamSpec* pspec = gst_property_probe_get_property(probe, "device");

If think a if (pspec) test is missing here.

[Philippe Normand]

Comment on attachment 80414 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80414&action=review

oh, also this question :)

> Source/WebCore/platform/device/gstreamer/StreamDeviceManagerPrivateGStreamer.cpp:43
> +#define GST_AUDIO_SRC_ELEMENT "alsasrc"

what about using autoaudiosrc and autovideosrc ? The #if could be avoid in that case.

[Adam Bergkvist]

(In reply to comment #3)
> what about using autoaudiosrc and autovideosrc ? The #if could be avoid in that case.

Yes, that's something we should try

[Adam Bergkvist]

Created attachment 81091 [details]
Updated patch

Main reason for update is to match the patch on which this patch depends.

Added null-check on pspec.
We've done some experimenting with "auto-sources", but I haven't included it in this patch.

[Adam Bergkvist]

Resolved as WONTFIX since the device element has been removed from the spec.

[Eric Seidel (no email)]

Comment on attachment 81091 [details]
Updated patch

Cleared review? from attachment 81091 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).