Bug 53242 - Web Inspector: [STYLES] Cancelled suggestion of a property name results in a visual artifact
Summary: Web Inspector: [STYLES] Cancelled suggestion of a property name results in a ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-27 08:45 PST by Alexander Pavlov (apavlov)
Modified: 2011-01-27 22:01 PST (History)
14 users (show)

See Also:


Attachments
[PATCH] Suggested fix (1.76 KB, patch)
2011-01-27 08:54 PST, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff
[PATCH] Comment addressed (2.49 KB, patch)
2011-01-27 09:32 PST, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2011-01-27 08:45:57 PST
1. Double-click a property name (e.g. "color") and type in some other name prefix, e.g. "bo". "border" is suggested
2. Press Esc to cancel the property rename.

As a result, "bocolor" remains in place of the property name ("bo" in black color). Another double-click + Esc fixes the display (the actual property name is not affected by the issue).
Comment 1 Alexander Pavlov (apavlov) 2011-01-27 08:54:36 PST
Created attachment 80335 [details]
[PATCH] Suggested fix
Comment 2 Yury Semikhatsky 2011-01-27 09:17:25 PST
Comment on attachment 80335 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=80335&action=review

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1727
> +            this._prompt.removeFromElement();

I don't quite understand why we detach the prompt from its parent here and don't do this on commit, can you explain this?
Comment 3 Alexander Pavlov (apavlov) 2011-01-27 09:32:11 PST
Created attachment 80341 [details]
[PATCH] Comment addressed

You are correct, this removal should be invoked in all cases. Fixed.
Comment 4 WebKit Commit Bot 2011-01-27 20:14:50 PST
Comment on attachment 80341 [details]
[PATCH] Comment addressed

Clearing flags on attachment: 80341

Committed r76913: <http://trac.webkit.org/changeset/76913>
Comment 5 WebKit Commit Bot 2011-01-27 20:14:54 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2011-01-27 22:01:36 PST
http://trac.webkit.org/changeset/76913 might have broken Leopard Intel Release (Tests)