Bug 53242 – Web Inspector: [STYLES] Cancelled suggestion of a property name results in a visual artifact

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

1. Double-click a property name (e.g. "color") and type in some other name prefix, e.g. "bo". "border" is suggested
2. Press Esc to cancel the property rename.

As a result, "bocolor" remains in place of the property name ("bo" in black color). Another double-click + Esc fixes the display (the actual property name is not affected by the issue).

[Alexander Pavlov (apavlov)]

Created attachment 80335 [details]
[PATCH] Suggested fix

[Yury Semikhatsky]

Comment on attachment 80335 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=80335&action=review

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1727
> +            this._prompt.removeFromElement();

I don't quite understand why we detach the prompt from its parent here and don't do this on commit, can you explain this?

[Alexander Pavlov (apavlov)]

Created attachment 80341 [details]
[PATCH] Comment addressed

You are correct, this removal should be invoked in all cases. Fixed.

[WebKit Commit Bot]

Comment on attachment 80341 [details]
[PATCH] Comment addressed

Clearing flags on attachment: 80341

Committed r76913: <http://trac.webkit.org/changeset/76913>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/76913 might have broken Leopard Intel Release (Tests)