Bug 53236 - Web Inspector: [Extensions API] add JSON schema for extensions API
Summary: Web Inspector: [Extensions API] add JSON schema for extensions API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-27 05:27 PST by Andrey Kosyakov
Modified: 2011-01-28 08:06 PST (History)
11 users (show)

See Also:

Attachments
patch (17.78 KB, patch)
2011-01-27 05:32 PST, Andrey Kosyakov 		no flags Details | Formatted Diff | Diff
patch (17.80 KB, patch)
2011-01-27 09:21 PST, Andrey Kosyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-01-27 05:27:32 PST 
This is currently so that docs may be generated for the schema. In the future, the schema should be used for generating client and server API stubs and validating parameters.
Comment 1 Andrey Kosyakov 2011-01-27 05:32:58 PST 
Created attachment 80324 [details]
patch
Comment 2 Andrey Kosyakov 2011-01-27 09:21:56 PST 
Created attachment 80340 [details]
patch

- Cleaned up JSON problems (trailing commas, string concatenation with "+")
- Moved to namespace experimental.webInspector
Comment 3 Pavel Feldman 2011-01-28 01:24:40 PST 
Comment on attachment 80340 [details]
patch

I'd suggest that we place it under WebKit/chromium/src/js.
Comment 4 Andrey Kosyakov 2011-01-28 05:34:10 PST 
(In reply to comment #3)
> (From update of attachment 80340 [details])
> I'd suggest that we place it under WebKit/chromium/src/js.

As discussed offline, we'd like this to be close to ExtensionAPI.js and ExtensionServer.js, as these need to be kept in-sync (manually for now, but ultimately we're looking to generate them from the schema). Also, this is a platform-neutral format that would be handy to generate platform-specific docs from, should other vendors wish to enable WebInspector extensions in their browsers.
Comment 5 WebKit Commit Bot 2011-01-28 08:06:23 PST 
Comment on attachment 80340 [details]
patch

Clearing flags on attachment: 80340

Committed r76945: <http://trac.webkit.org/changeset/76945>
Comment 6 WebKit Commit Bot 2011-01-28 08:06:27 PST 
All reviewed patches have been landed.  Closing bug.