new-run-webkit-tests: turn off pixel tests correctly by default for webkit-based ports
Created attachment 80284 [details] Patch
Created attachment 80285 [details] fix so that you can still manually enable pixel tests
Comment on attachment 80285 [details] fix so that you can still manually enable pixel tests View in context: https://bugs.webkit.org/attachment.cgi?id=80285&action=review > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:60 > + if not hasattr(self._options, "pixel_tests") or self._options.pixel_tests == None: I think the condition "not get_option('pixel_tests')" should result in the same behavior.
(In reply to comment #3) > (From update of attachment 80285 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=80285&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:60 > > + if not hasattr(self._options, "pixel_tests") or self._options.pixel_tests == None: > > I think the condition "not get_option('pixel_tests')" should result in the same behavior. "not get_option('pixel_tests')" would be True if was set to False. Which, in this case, would be harmless, but if you wanted the default to be True, would do the wrong thing, so probably better to leave it as it is.
Comment on attachment 80285 [details] fix so that you can still manually enable pixel tests View in context: https://bugs.webkit.org/attachment.cgi?id=80285&action=review > Tools/Scripts/webkitpy/layout_tests/port/base.py:126 > + if not hasattr(self._options, 'configuration'): > + self._options.configuration = None > if self._options.configuration is None: seems sily. Why not combine these two with an or?
(In reply to comment #5) > (From update of attachment 80285 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=80285&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/base.py:126 > > + if not hasattr(self._options, 'configuration'): > > + self._options.configuration = None > > if self._options.configuration is None: > > seems sily. Why not combine these two with an or? Can do!
Committed r76829: <http://trac.webkit.org/changeset/76829>
http://trac.webkit.org/changeset/76829 might have broken GTK Linux 32-bit Release The following tests are not passing: svg/animations/animate-text-nested-transforms.html