RESOLVED FIXED 53217
new-run-webkit-tests: turn off pixel tests correctly by default for webkit-based ports 
https://bugs.webkit.org/show_bug.cgi?id=53217
Summary new-run-webkit-tests: turn off pixel tests correctly by default for webkit-ba...
Dirk Pranke
Reported 2011-01-26 17:41:33 PST
new-run-webkit-tests: turn off pixel tests correctly by default for webkit-based ports
Attachments
Patch (4.32 KB, patch)
2011-01-26 17:56 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
fix so that you can still manually enable pixel tests (4.42 KB, patch)
2011-01-26 18:17 PST, Dirk Pranke 		mihaip: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-01-26 17:56:59 PST
Created attachment 80284 [details] Patch
Dirk Pranke
Comment 2 2011-01-26 18:17:27 PST
Created attachment 80285 [details] fix so that you can still manually enable pixel tests
Mihai Parparita
Comment 3 2011-01-26 18:21:40 PST
Comment on attachment 80285 [details] fix so that you can still manually enable pixel tests View in context: https://bugs.webkit.org/attachment.cgi?id=80285&action=review > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:60 > + if not hasattr(self._options, "pixel_tests") or self._options.pixel_tests == None: I think the condition "not get_option('pixel_tests')" should result in the same behavior.
Dirk Pranke
Comment 4 2011-01-26 22:35:05 PST
(In reply to comment #3) > (From update of attachment 80285 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=80285&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:60 > > + if not hasattr(self._options, "pixel_tests") or self._options.pixel_tests == None: > > I think the condition "not get_option('pixel_tests')" should result in the same behavior. "not get_option('pixel_tests')" would be True if was set to False. Which, in this case, would be harmless, but if you wanted the default to be True, would do the wrong thing, so probably better to leave it as it is.
Eric Seidel (no email)
Comment 5 2011-01-26 22:48:38 PST
Comment on attachment 80285 [details] fix so that you can still manually enable pixel tests View in context: https://bugs.webkit.org/attachment.cgi?id=80285&action=review > Tools/Scripts/webkitpy/layout_tests/port/base.py:126 > + if not hasattr(self._options, 'configuration'): > + self._options.configuration = None > if self._options.configuration is None: seems sily. Why not combine these two with an or?
Dirk Pranke
Comment 6 2011-01-26 23:20:59 PST
(In reply to comment #5) > (From update of attachment 80285 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=80285&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/base.py:126 > > + if not hasattr(self._options, 'configuration'): > > + self._options.configuration = None > > if self._options.configuration is None: > > seems sily. Why not combine these two with an or? Can do!
Dirk Pranke
Comment 7 2011-01-27 12:54:11 PST
Committed r76829: <http://trac.webkit.org/changeset/76829>
WebKit Review Bot
Comment 8 2011-01-27 14:21:31 PST
http://trac.webkit.org/changeset/76829 might have broken GTK Linux 32-bit Release The following tests are not passing: svg/animations/animate-text-nested-transforms.html
Note You need to log in before you can comment on or make changes to this bug.