Bug 53208 - BinarySemaphore should wrap a Win32 event
Summary: BinarySemaphore should wrap a Win32 event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks: 53209
  Show dependency tree / graph
 
Reported: 2011-01-26 17:23 PST by Adam Roben (:aroben)
Modified: 2011-01-28 12:48 PST (History)
5 users (show)

See Also:

Attachments
Change BinarySemaphore to wrap an auto-reset Win32 event on Windows (12.02 KB, patch)
2011-01-27 18:45 PST, Adam Roben (:aroben) 		hyatt: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-01-26 17:23:26 PST 
BinarySemaphore should wrap a Win32 event. This will make it more efficient, and make it able to be used in functions like ::WaitForMultipleObjects.
Comment 1 Anders Carlsson 2011-01-26 18:15:58 PST 
<rdar://problem/8922490>
Comment 2 Adam Roben (:aroben) 2011-01-27 18:45:30 PST 
Created attachment 80398 [details]
Change BinarySemaphore to wrap an auto-reset Win32 event on Windows
Comment 3 Dave Hyatt 2011-01-27 18:53:01 PST 
Comment on attachment 80398 [details]
Change BinarySemaphore to wrap an auto-reset Win32 event on Windows

Looks fine. r=me
Comment 4 Adam Roben (:aroben) 2011-01-28 12:20:35 PST 
Fixed in r76967.
Comment 5 Adam Roben (:aroben) 2011-01-28 12:20:46 PST 
...so I should close the bug.
Comment 6 WebKit Review Bot 2011-01-28 12:48:09 PST 
http://trac.webkit.org/changeset/76967 might have broken Chromium Win Release