Bug 53200 - Generalize the mechanism view-sources uses to remember the source for an HTMLToken
Summary: Generalize the mechanism view-sources uses to remember the source for an HTML...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 49845
  Show dependency treegraph
 
Reported: 2011-01-26 15:48 PST by Adam Barth
Modified: 2011-01-27 13:53 PST (History)
2 users (show)

See Also:


Attachments
Patch (25.45 KB, patch)
2011-01-26 15:58 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (24.90 KB, patch)
2011-01-27 12:04 PST, Adam Barth
abarth: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-01-26 15:48:03 PST
Generalize the mechanism view-sources uses to remember the source for an HTMLToken
Comment 1 Adam Barth 2011-01-26 15:58:07 PST
Created attachment 80251 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-01-26 16:22:39 PST
Comment on attachment 80251 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80251&action=review

This seems sane.  Thank you for keeping it small.

> Source/WebCore/ChangeLog:37
> +            - This function should eventuall be folded into HTMLTokenizer.

eventuall

> Source/WebCore/html/parser/HTMLSourceTracker.cpp:44
> +    token.end(input.current().numberOfCharactersConsumed());

You shoudl add a FIXME about moving this to the tokenizer.

> Source/WebCore/html/parser/HTMLSourceTracker.h:39
> +    void start(const HTMLInputStream&, HTMLToken&);

You should make it clear that this can be called multipel times.
Comment 3 Adam Barth 2011-01-27 12:04:47 PST
Created attachment 80353 [details]
Patch for landing
Comment 4 Adam Barth 2011-01-27 13:53:18 PST
Committed r76835: <http://trac.webkit.org/changeset/76835>