Bug 53179 - [chromium] Implement reflections for composited layers
Summary: [chromium] Implement reflections for composited layers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vangelis Kokkevis
URL:
Keywords:
Depends on:
Blocks: 53679
  Show dependency treegraph
 
Reported: 2011-01-26 10:39 PST by Vangelis Kokkevis
Modified: 2011-02-03 17:39 PST (History)
4 users (show)

See Also:


Attachments
Patch (16.51 KB, patch)
2011-02-01 14:19 PST, Vangelis Kokkevis
kbr: review+
vangelis: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vangelis Kokkevis 2011-01-26 10:39:48 PST
Add support for the -webkit-box-reflect property
Comment 1 Vangelis Kokkevis 2011-02-01 14:19:18 PST
Created attachment 80825 [details]
Patch
Comment 2 Kenneth Russell 2011-02-01 14:48:04 PST
Comment on attachment 80825 [details]
Patch

Looks good to me, in particular the drawableContentRect() refactoring. Do we need test expectations updates for the chromium-gpu port?
Comment 3 Vangelis Kokkevis 2011-02-02 15:08:52 PST
Committed r77425: <http://trac.webkit.org/changeset/77425>
Comment 4 Vangelis Kokkevis 2011-02-02 15:10:06 PST
(In reply to comment #2)
> (From update of attachment 80825 [details])
> Looks good to me, in particular the drawableContentRect() refactoring. Do we need test expectations updates for the chromium-gpu port?

New test expectations will be harvested from build bots and updated once the patch lands.  At the moment all compositing tests are marked as PASS FAIL so they won't turn the chromium-gpu bot red.
Comment 5 Jonathan Backer 2011-02-03 06:38:08 PST
Regression on http://webkit.org/blog/386/3d-transforms/

ASSERTION FAILED: m_ptr
(third_party/WebKit/Source/JavaScriptCore/wtf/OwnPtr.h:66 typename WTF::RemovePointer<T>::Type* WTF::OwnPtr<T>::operator->() const [with T = WebCore::RenderSurfaceChromium])

This is on the Linux build. The regression first occurred on a WebKit roll (chromium r73597). From this, I narrowed it down to this particular WebKit commit.
Comment 6 Jonathan Backer 2011-02-03 06:55:58 PST
Based on advice from #webkit, I've filed a separate bug for the regression (https://bugs.webkit.org/show_bug.cgi?id=53679).