Web Inspector: [Elements panel] Tooltip for relative links incorrectly identifies current URL

[Alexander Pavlov (apavlov)]

1. Go to youtube.com/gaming.
2. Scroll down the the pagination controls below the video grid.
3. Right click -> inspect element on one of the numbers.
4. Hover over href="?s=pop&t=t&c=20&cr=US&p=2"

What is the expected result?
  Tooltip says "www.youtube.com/?s=pop&t=t&c=20&cr=US&p=2"
What happens instead?
  Tooltip says "www.youtube.com/gaming?s=pop&t=t&c=20&cr=US&p=2"

Upstreaming http://code.google.com/p/chromium/issues/detail?id=67762

[Alexander Pavlov (apavlov)]

This appears to work fine on ToT

[Alexander Pavlov (apavlov)]

The issue exists but the original upstream report was wrong. It should read:

The EXPECTED result is:
www.youtube.com/gaming?s=pop&t=t&c=20&cr=US&p=2

but the ACTUAL result (what happens instead) is:
www.youtube.com/?s=pop&t=t&c=20&cr=US&p=2

[Alexander Pavlov (apavlov)]

Created attachment 80313 [details]
[PATCH] Suggested fix

[Pavel Feldman]

Comment on attachment 80313 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=80313&action=review

> Source/WebCore/inspector/front-end/inspector.js:1518
> +            // A href of "?foo=bar" implies "basePath?foo=bar".

Can we get a test for it? Should simply dump a number of WebInspector.completeURL invocations. Otherwise looks good.

[Alexander Pavlov (apavlov)]

Created attachment 80320 [details]
[PATCH] Comment addressed

[Alexander Pavlov (apavlov)]

Comment on attachment 80320 [details]
[PATCH] Comment addressed

Committed manually: http://trac.webkit.org/changeset/76788

[WebKit Review Bot]

http://trac.webkit.org/changeset/76788 might have broken GTK Linux 32-bit Release