Bug 53171 - Web Inspector: [Elements panel] Tooltip for relative links incorrectly identifies current URL
Summary: Web Inspector: [Elements panel] Tooltip for relative links incorrectly identi...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
Depends on:
Reported: 2011-01-26 08:07 PST by Alexander Pavlov (apavlov)
Modified: 2011-01-27 06:21 PST (History)
13 users (show)

See Also:

[PATCH] Suggested fix (2.18 KB, patch)
2011-01-27 03:22 PST, Alexander Pavlov (apavlov)
pfeldman: review-
Details | Formatted Diff | Diff
[PATCH] Comment addressed (5.47 KB, patch)
2011-01-27 04:32 PST, Alexander Pavlov (apavlov)
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2011-01-26 08:07:50 PST
1. Go to youtube.com/gaming.
2. Scroll down the the pagination controls below the video grid.
3. Right click -> inspect element on one of the numbers.
4. Hover over href="?s=pop&t=t&c=20&cr=US&p=2"

What is the expected result?
  Tooltip says "www.youtube.com/?s=pop&t=t&c=20&cr=US&p=2"
What happens instead?
  Tooltip says "www.youtube.com/gaming?s=pop&t=t&c=20&cr=US&p=2"

Upstreaming http://code.google.com/p/chromium/issues/detail?id=67762
Comment 1 Alexander Pavlov (apavlov) 2011-01-26 08:35:38 PST
This appears to work fine on ToT
Comment 2 Alexander Pavlov (apavlov) 2011-01-27 02:12:31 PST
The issue exists but the original upstream report was wrong. It should read:

The EXPECTED result is:

but the ACTUAL result (what happens instead) is:
Comment 3 Alexander Pavlov (apavlov) 2011-01-27 03:22:07 PST
Created attachment 80313 [details]
[PATCH] Suggested fix
Comment 4 Pavel Feldman 2011-01-27 04:05:11 PST
Comment on attachment 80313 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=80313&action=review

> Source/WebCore/inspector/front-end/inspector.js:1518
> +            // A href of "?foo=bar" implies "basePath?foo=bar".

Can we get a test for it? Should simply dump a number of WebInspector.completeURL invocations. Otherwise looks good.
Comment 5 Alexander Pavlov (apavlov) 2011-01-27 04:32:24 PST
Created attachment 80320 [details]
[PATCH] Comment addressed
Comment 6 Alexander Pavlov (apavlov) 2011-01-27 04:56:16 PST
Comment on attachment 80320 [details]
[PATCH] Comment addressed

Committed manually: http://trac.webkit.org/changeset/76788
Comment 7 WebKit Review Bot 2011-01-27 06:21:57 PST
http://trac.webkit.org/changeset/76788 might have broken GTK Linux 32-bit Release