Bug 53167 - Web Inspector: [Chromium] Incorrect JavaScript exception throw with wrong line number for invalid on* attribute.
Summary: Web Inspector: [Chromium] Incorrect JavaScript exception throw with wrong li...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-26 04:46 PST by Pavel Feldman
Modified: 2013-04-05 13:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.68 KB, patch)
2011-01-26 04:50 PST, Pavel Feldman 		pfeldman: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-01-26 04:46:39 PST 
Upstreamed from http://code.google.com/p/chromium/issues/detail?id=70895
Comment 1 Pavel Feldman 2011-01-26 04:50:00 PST 
Created attachment 80184 [details]
Patch
Comment 2 Pavel Feldman 2011-01-26 04:53:48 PST 
This patch is taken from downstream bug, should have Berend-Jan Wever as author. Please fix upon landing.
Comment 3 Pavel Feldman 2011-01-26 04:58:09 PST 
Comment on attachment 80184 [details]
Patch

Putting reviewer hat on now... We should not parse snippet twice. Probably we could do some line number math based on the wrapper structure.
Comment 4 Berend-Jan Wever 2011-01-26 06:50:01 PST 
But even if you fix the line number, you still get the wrong error message.
Comment 5 Yury Semikhatsky 2011-01-27 01:18:12 PST 
I think correct fix would be to compile the wrapper and the handler separately and then provide a way to execute the handler in the context of the wrapper. Achieving this without observable performance hit would be a challenging task though.
Comment 6 Timothy Hatcher 2013-04-05 13:00:51 PDT 
Chromium and V8 have left the building. Won't fix.