WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
53167
Web Inspector: [Chromium] Incorrect JavaScript exception throw with wrong line number for invalid on* attribute.
https://bugs.webkit.org/show_bug.cgi?id=53167
Summary
Web Inspector: [Chromium] Incorrect JavaScript exception throw with wrong li...
Pavel Feldman
Reported
2011-01-26 04:46:39 PST
Upstreamed from
http://code.google.com/p/chromium/issues/detail?id=70895
Attachments
Patch
(2.68 KB, patch)
2011-01-26 04:50 PST
,
Pavel Feldman
pfeldman
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2011-01-26 04:50:00 PST
Created
attachment 80184
[details]
Patch
Pavel Feldman
Comment 2
2011-01-26 04:53:48 PST
This patch is taken from downstream bug, should have Berend-Jan Wever as author. Please fix upon landing.
Pavel Feldman
Comment 3
2011-01-26 04:58:09 PST
Comment on
attachment 80184
[details]
Patch Putting reviewer hat on now... We should not parse snippet twice. Probably we could do some line number math based on the wrapper structure.
Berend-Jan Wever
Comment 4
2011-01-26 06:50:01 PST
But even if you fix the line number, you still get the wrong error message.
Yury Semikhatsky
Comment 5
2011-01-27 01:18:12 PST
I think correct fix would be to compile the wrapper and the handler separately and then provide a way to execute the handler in the context of the wrapper. Achieving this without observable performance hit would be a challenging task though.
Timothy Hatcher
Comment 6
2013-04-05 13:00:51 PDT
Chromium and V8 have left the building. Won't fix.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug