Bug 53162 - Web Inspector: visualize \n in strings as ↵ in stack variables sidebar.
Summary: Web Inspector: visualize \n in strings as ↵ in stack variables sidebar.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-25 23:33 PST by Pavel Feldman
Modified: 2020-02-09 15:01 PST (History)
10 users (show)

See Also:

Attachments
[PATCH] Proposed change. (1.59 KB, patch)
2011-01-26 08:38 PST, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-01-25 23:33:54 PST 
Upstreamed from crbug.com/32855.
Comment 1 Patrick Mueller 2011-01-26 06:45:34 PST 
Great idea.  Perhaps some others as well, like tab as → (right pointing arrow)
Comment 2 Pavel Feldman 2011-01-26 08:38:14 PST 
Created attachment 80197 [details]
[PATCH] Proposed change.
Comment 3 Yury Semikhatsky 2011-01-26 09:03:31 PST 
Comment on attachment 80197 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=80197&action=review

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:186
> +            description = description.replace(/\n/g, "\u21B5");

A short comment would be helpful here.
Comment 4 Joseph Pecoraro 2011-01-26 09:10:51 PST 
Comment on attachment 80197 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=80197&action=review

>> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:186
>> +            description = description.replace(/\n/g, "\u21B5");
> 
> A short comment would be helpful here.

yurys++
Comment 5 Pavel Feldman 2011-01-26 09:19:35 PST 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/inspector/front-end/ObjectPropertiesSection.js
Committed r76692