Bug 53157 - new-run-webkit-tests: add first stub of test_runner2
Summary: new-run-webkit-tests: add first stub of test_runner2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on: 53156
Blocks: 49566 53158
  Show dependency treegraph
 
Reported: 2011-01-25 19:37 PST by Dirk Pranke
Modified: 2011-02-01 17:16 PST (History)
4 users (show)

See Also:


Attachments
Patch (7.53 KB, patch)
2011-01-25 19:45 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
update w/ review feedback from tony (7.77 KB, patch)
2011-02-01 17:00 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-01-25 19:37:37 PST
new-run-webkit-tests: add first stub of test_runner2
Comment 1 Dirk Pranke 2011-01-25 19:45:10 PST
Created attachment 80162 [details]
Patch
Comment 2 Tony Chang 2011-02-01 15:32:51 PST
Comment on attachment 80162 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80162&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:34
> +The TestRunner class runs a series of tests (TestType interface) against a set
> +of test files.  If a test file fails a TestType, it returns a list TestFailure
> +objects to the TestRunner.  The TestRunner then aggregates the TestFailures to
> +create a final report.

This comment doesn't seem to describe this file (TestRunner2).  Maybe mention what this is going to be used for and what it does now.

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:468
> +

Can you add a test with --child-processes and --worker-model?
Comment 3 Dirk Pranke 2011-02-01 16:40:15 PST
(In reply to comment #2)
> (From update of attachment 80162 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=80162&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:34
> > +The TestRunner class runs a series of tests (TestType interface) against a set
> > +of test files.  If a test file fails a TestType, it returns a list TestFailure
> > +objects to the TestRunner.  The TestRunner then aggregates the TestFailures to
> > +create a final report.
> 
> This comment doesn't seem to describe this file (TestRunner2).  Maybe mention what this is going to be used for and what it does now.
> 

Yeah, looks like I just copied&pasted that from the old file and it's not even a very good comment. I'll put in something better.

> > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:468
> > +
> 
> Can you add a test with --child-processes and --worker-model?

Will do.
Comment 4 Dirk Pranke 2011-02-01 17:00:43 PST
Created attachment 80857 [details]
update w/ review feedback from tony
Comment 5 Dirk Pranke 2011-02-01 17:16:38 PST
Committed r77341: <http://trac.webkit.org/changeset/77341>