Bug 53151 - Range and number inputs should reject increment and decrement by keyboard or mouse wheel if they are disabled or read-only
Summary: Range and number inputs should reject increment and decrement by keyboard or ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kent Tamura
URL: http://code.google.com/p/chromium/iss...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-25 17:39 PST by Kent Tamura
Modified: 2011-01-25 20:53 PST (History)
7 users (show)

See Also:

Attachments
Patch (7.64 KB, patch)
2011-01-25 17:41 PST, Kent Tamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-01-25 17:39:11 PST 
Range and number inputs should reject increment and decrement by keyboard or mouse wheel if they are disabled or read-only
Comment 1 Kent Tamura 2011-01-25 17:41:38 PST 
Created attachment 80150 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-01-25 17:45:35 PST 
Comment on attachment 80150 [details]
Patch

ok. Is this the typical way we handle disabled and readOnly for elements?
Comment 3 Kent Tamura 2011-01-25 17:49:39 PST 
(In reply to comment #2)
> ok. Is this the typical way we handle disabled and readOnly for elements?

I think we have no other way.
e.g. We can't skip all of key event handling in HTMLInputElement.cpp because we'd like to handle ⌘-C or Ctrl-c even if the element is disabled or read-only.
Comment 4 Kent Tamura 2011-01-25 19:51:03 PST 
Comment on attachment 80150 [details]
Patch

Clearing flags on attachment: 80150

Committed r76662: <http://trac.webkit.org/changeset/76662>
Comment 5 Kent Tamura 2011-01-25 19:51:11 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2011-01-25 20:53:46 PST 
http://trac.webkit.org/changeset/76662 might have broken Leopard Intel Release (Tests)