initial support for close() in indexeddb backend
Created attachment 80153 [details]
Comment on attachment 80153 [details]
change the idl and add a test please
Created attachment 80267 [details]
Comment on attachment 80267 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=80267&action=review
> + evalAndLog("objectStore.put('a', 'b')");
Whenever you do something, you should at least set an onerror handler to be unexpectedErrorCallback
> + currentTransaction.onabort = done;
It's probably worth doing something on this transaction and verifying its onsuccess fires
> + : m_backend(backend), m_noNewTransactions(false)
, and such on newline
> - m_backend->close();
The setVersion logic is going to need to run in the backend, so you still need to do this.
> + m_noNewTransactions = true;
Right now, we try to do as much of the logic as is possible in the backend. I think we should probably move this there especially since we need to plumb close anyway.
> + bool m_noNewTransactions;
this should be on the backend object
Oh...the logic does need to be in the frontend. OK....but still do the layout test and style nits.
Created attachment 80283 [details]
Comment on attachment 80283 [details]