Bug 53143 – Add IntRectHash

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Alexey Proskuryakov]

To use IntRect as a key in a rect->PDF cache of page previews in WebKit2.

[Alexey Proskuryakov]

Created attachment 80145 [details]
proposed patch

[WebKit Review Bot]

Attachment 80145 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/graphics/IntRectHash.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/graphics/IntRectHash.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/platform/graphics/IntRectHash.h:48:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/platform/graphics/IntSizeHash.h:29:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/platform/graphics/IntSizeHash.h:34:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 5 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 80145 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80145&action=review

>> Source/WebCore/platform/graphics/IntRectHash.h:30
>> +#include "IntPointHash.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

I agree with the style bot.

>> Source/WebCore/platform/graphics/IntRectHash.h:37
>> +    template<> struct IntHash<WebCore::IntRect> {
> 
> Code inside a namespace should not be indented.  [whitespace/indent] [4]

I agree with the style bot.

>> Source/WebCore/platform/graphics/IntRectHash.h:48
>> +    template<> struct DefaultHash<WebCore::IntRect> { typedef IntHash<WebCore::IntRect> Hash; };
> 
> More than one command on the same line  [whitespace/newline] [4]

This is a false positive from the style bot.

>> Source/WebCore/platform/graphics/IntSizeHash.h:29
>> +    template<> struct IntHash<WebCore::IntSize> {
> 
> Code inside a namespace should not be indented.  [whitespace/indent] [4]

I agree with the style bot, but I’m not sure we should re-indent the whole file.

>> Source/WebCore/platform/graphics/IntSizeHash.h:34
>> +    template<> struct DefaultHash<WebCore::IntSize> { typedef IntHash<WebCore::IntSize> Hash; };
> 
> More than one command on the same line  [whitespace/newline] [4]

False positive from the style bot.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/76660>.