Bug 5310 - Switch QRegion from using NSBezierPath to CGPath
Summary: Switch QRegion from using NSBezierPath to CGPath
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P3 Enhancement
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-09 15:25 PDT by mitz
Modified: 2006-03-29 14:54 PST (History)
0 users

See Also:

Attachments
replace the NSBezierPath with a CGPath (3.53 KB, patch)
2005-10-09 15:26 PDT, mitz 		darin: review-
Details | Formatted Diff | Diff
replace the NSBezierPath with a CGPath (3.71 KB, patch)
2005-10-10 10:46 PDT, mitz 		hyatt: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2005-10-09 15:25:26 PDT
Comment 1 mitz 2005-10-09 15:26:41 PDT 
Created attachment 4272 [details]
replace the NSBezierPath with a CGPath
Comment 2 mitz 2005-10-09 15:28:43 PDT 
Comment on attachment 4272 [details]
replace the NSBezierPath with a CGPath

I thought it might solve an issue with [NSBezierPath containsPoint:] not always
returning YES when it should, but CGPath has the same problem.
Comment 3 Darin Adler 2005-10-09 15:58:25 PDT 
Comment on attachment 4272 [details]
replace the NSBezierPath with a CGPath

We use 0 instead of NULL in our code.

Otherwise looks perfect!
Comment 4 mitz 2005-10-10 10:46:49 PDT 
Created attachment 4292 [details]
replace the NSBezierPath with a CGPath

Changed NULLs to 0s and removed NSBezierPath comment
Comment 5 Dave Hyatt 2005-10-17 20:45:11 PDT 
Comment on attachment 4292 [details]
replace the NSBezierPath with a CGPath

r=me
Comment 6 Eric Seidel (no email) 2005-11-29 02:10:32 PST 
Landed.
Comment 7 Darin Adler 2006-03-29 06:31:01 PST 
Turns out this caused a bug. Currently the bug report is only in Bugzilla, but there seem to be cases that NSBezierPath handles better than CGPath. Specifically:

    http://www.intervalworld.com/web/cs?a=1500

On that map if you mouse over the US you'll get some areas that say "Europe" or "Asia".
Comment 8 mitz 2006-03-29 14:54:56 PST 
(In reply to comment #7)
> Turns out this caused a bug. Currently the bug report is only in Bugzilla, but
> there seem to be cases that NSBezierPath handles better than CGPath.

And there are cases that CGPath handles better the NSBezierPath. I don't know which are more common.