Bug 53084 - [cairo] Use CAIRO_OPERATOR_DARKEN when available
Summary: [cairo] Use CAIRO_OPERATOR_DARKEN when available
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-25 06:58 PST by Carlos Garcia Campos
Modified: 2011-01-26 10:17 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2011-01-25 07:03 PST, Carlos Garcia Campos 		mrobinson: review-
Details | Formatted Diff | Diff
Updated patch with unskipped test (9.00 KB, patch)
2011-01-26 03:19 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-01-25 06:58:57 PST 
We are currenlty using CAIRO_OPERATOR_SATURATE for CompositePlusDarker which is wrong. Since cairo 1.10 there's CAIRO_OPERATOR_DARKEN that we could use.
Comment 1 Carlos Garcia Campos 2011-01-25 07:03:37 PST 
Created attachment 80062 [details]
Patch

This would allow us to unskip test fast/canvas/canvas-composite.html but bots don't have cairo 1.10 :-(
Comment 2 Martin Robinson 2011-01-25 08:54:20 PST 
Great. Hopefully we can get the bots up to date. This may not be an issue for too much longer though: https://bugs.webkit.org/show_bug.cgi?id=43739
Comment 3 Martin Robinson 2011-01-25 13:49:30 PST 
Comment on attachment 80062 [details]
Patch

This looks great to me, but we should also unskip the test now that the bots have the necessary Cairo version.
Comment 4 Carlos Garcia Campos 2011-01-26 03:19:45 PST 
Created attachment 80178 [details]
Updated patch with unskipped test
Comment 5 Carlos Garcia Campos 2011-01-26 10:17:26 PST 
Committed r76697: <http://trac.webkit.org/changeset/76697>