Bug 53077 - IndexedDB: Remove PlatformBridge::idbShutdown()
Summary: IndexedDB: Remove PlatformBridge::idbShutdown()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Hans Wennborg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-25 04:26 PST by Hans Wennborg
Modified: 2011-01-25 12:07 PST (History)
6 users (show)

See Also:


Attachments
Patch (5.91 KB, patch)
2011-01-25 04:28 PST, Hans Wennborg
no flags Details | Formatted Diff | Diff
Patch (6.15 KB, patch)
2011-01-25 06:07 PST, Hans Wennborg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2011-01-25 04:26:03 PST
IndexedDB: Remove PlatformBridge::idbShutdown()
Comment 1 Hans Wennborg 2011-01-25 04:28:33 PST
Created attachment 80047 [details]
Patch
Comment 2 Andrei Popescu 2011-01-25 04:32:18 PST
I think you should explain in the Changelog why this isn't needed anymore.
Comment 3 Hans Wennborg 2011-01-25 06:07:22 PST
Created attachment 80056 [details]
Patch

Hopefully better ChangeLogs
Comment 4 Andrei Popescu 2011-01-25 06:35:32 PST
LGTM
Comment 5 Jeremy Orlow 2011-01-25 09:19:41 PST
Comment on attachment 80056 [details]
Patch

r=me

why not remove this from the webkitclient interface in this patch too tho?
Comment 6 Hans Wennborg 2011-01-25 09:23:13 PST
(In reply to comment #5)
> (From update of attachment 80056 [details])
> r=me
> 
> why not remove this from the webkitclient interface in this patch too tho?

I thought I did, in Source/WebKit/chromium/public/WebKitClient.h ?
Comment 7 Jeremy Orlow 2011-01-25 09:30:29 PST
oops...missed it
Comment 8 WebKit Commit Bot 2011-01-25 11:07:20 PST
Comment on attachment 80056 [details]
Patch

Clearing flags on attachment: 80056

Committed r76616: <http://trac.webkit.org/changeset/76616>
Comment 9 WebKit Commit Bot 2011-01-25 11:07:25 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 WebKit Review Bot 2011-01-25 12:07:20 PST
http://trac.webkit.org/changeset/76616 might have broken Leopard Intel Release (Tests)