RESOLVED FIXED53066
Web Inspector: fix data url's status and timing the network panel. 
https://bugs.webkit.org/show_bug.cgi?id=53066
Summary Web Inspector: fix data url's status and timing the network panel.
Pavel Feldman
Reported 2011-01-24 22:23:45 PST
Today, data urls are shown as pending requests in the network panel. There should be no data urls in the network panel at all since there is no associated network request.
Attachments
Patch (2.36 KB, patch)
2011-04-05 09:13 PDT, Vsevolod Vlasov 		pfeldman: review-
DetailsFormatted DiffDiff
Patch with fixes (2.61 KB, patch)
2011-04-05 10:52 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-01-24 22:24:31 PST
(crbug.com/69810)
Vsevolod Vlasov
Comment 2 2011-04-05 09:13:15 PDT
Created attachment 88246 [details] Patch Data URL resources now show "(data url)" in status cell.
Pavel Feldman
Comment 3 2011-04-05 10:15:05 PDT
Comment on attachment 88246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88246&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:1524 > + this._statusCell.textContent = WebInspector.UIString("(data url)"); You need to update English.lproj/localizedStrings.js with new string. > Source/WebCore/inspector/front-end/NetworkPanel.js:1525 > + this._statusCell.addStyleClass("network-dim-cell"); Seems like this line is common. > Source/WebCore/inspector/front-end/Resource.js:716 > + isFromDataURL: function() nit: isDataURL
Vsevolod Vlasov
Comment 4 2011-04-05 10:52:41 PDT
Created attachment 88276 [details] Patch with fixes
WebKit Commit Bot
Comment 5 2011-04-05 14:59:27 PDT
Comment on attachment 88276 [details] Patch with fixes Clearing flags on attachment: 88276 Committed r82985: <http://trac.webkit.org/changeset/82985>
WebKit Commit Bot
Comment 6 2011-04-05 14:59:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.