Bug 53066 - Web Inspector: fix data url's status and timing the network panel.
Summary: Web Inspector: fix data url's status and timing the network panel.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-24 22:23 PST by Pavel Feldman
Modified: 2011-04-05 14:59 PDT (History)
11 users (show)

See Also:


Attachments
Patch (2.36 KB, patch)
2011-04-05 09:13 PDT, Vsevolod Vlasov
pfeldman: review-
Details | Formatted Diff | Diff
Patch with fixes (2.61 KB, patch)
2011-04-05 10:52 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-01-24 22:23:45 PST
Today, data urls are shown as pending requests in the network panel. There should be no data urls in the network panel at all since there is no associated network request.
Comment 1 Pavel Feldman 2011-01-24 22:24:31 PST
(crbug.com/69810)
Comment 2 Vsevolod Vlasov 2011-04-05 09:13:15 PDT
Created attachment 88246 [details]
Patch

Data URL resources now show "(data url)" in status cell.
Comment 3 Pavel Feldman 2011-04-05 10:15:05 PDT
Comment on attachment 88246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88246&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:1524
> +                this._statusCell.textContent = WebInspector.UIString("(data url)");

You need to update English.lproj/localizedStrings.js with new string.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1525
> +                this._statusCell.addStyleClass("network-dim-cell");

Seems like this line is common.

> Source/WebCore/inspector/front-end/Resource.js:716
> +    isFromDataURL: function()

nit: isDataURL
Comment 4 Vsevolod Vlasov 2011-04-05 10:52:41 PDT
Created attachment 88276 [details]
Patch with fixes
Comment 5 WebKit Commit Bot 2011-04-05 14:59:27 PDT
Comment on attachment 88276 [details]
Patch with fixes

Clearing flags on attachment: 88276

Committed r82985: <http://trac.webkit.org/changeset/82985>
Comment 6 WebKit Commit Bot 2011-04-05 14:59:31 PDT
All reviewed patches have been landed.  Closing bug.