It seems we can get rid of TestArgs class in new-run-webkit-tests. TestArgs class is defined in webkitpy/layout_tests/test_types/test_type_base.py.
TestArgs has fields of new_baseline, png_path, hash and wdiff, but only a new_baseline (and reset_results, which is wrongly assigned) field is used in actual code.
That class is used only in test_type::compare_output() as a parameter, but there TestArgs parameter can be replaced with 'options'.
Created attachment 80019 [details]
Yup, looks good to me (but I'm not a reviewer).
adding more people who are reviewers ...
Comment on attachment 80019 [details]
I fully support deleting code.
This patch (A) depends on other patch (B), https://bugs.webkit.org/show_bug.cgi?id=53004, which is under the review.
There is no strong relation between (A) and (B), but we should wait for patch (B) to apply this patch (A).
I'll set review flag and update this bugzilla entry once patch (B) is landed.
Created attachment 81188 [details]
The patch is now ready to be reviewed.
Comment on attachment 81188 [details]
Committed r77606: <http://trac.webkit.org/changeset/77606>