Bug 53062 – Leaking CSSRuleDataList objects

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Simon Fraser (smfr)]

Created attachment 80017 [details]
Leaks log

Running 'run-webkit-tests --debug --leaks LayoutTests/fast/css' shows some leaks of CSSRuleDataList objects.

On SnowLeopard, at r76568.

Massaged leaks output attached. Sample stack is:


	| WebCore::JSNode::appendChild(JSC::ExecState*)
	| WebCore::Node::appendChild(WTF::PassRefPtr<WebCore::Node>, int&, bool)
	| WebCore::ContainerNode::appendChild(WTF::PassRefPtr<WebCore::Node>, int&, bool)
	| WebCore::notifyChildInserted(WebCore::Node*)
	| WebCore::HTMLStyleElement::insertedIntoDocument()
	| WebCore::StyleElement::insertedIntoDocument(WebCore::Document*, WebCore::Element*)
	| WebCore::StyleElement::process(WebCore::Element*)
	| WebCore::StyleElement::createSheet(WebCore::Element*, int, WTF::String const&)
	| WebCore::CSSStyleSheet::checkLoaded()
	| WebCore::HTMLStyleElement::sheetLoaded()
	| WebCore::StyleElement::sheetLoaded(WebCore::Document*)
	| WebCore::Document::removePendingSheet()
	| WebCore::Document::styleSelectorChanged(WebCore::StyleSelectorUpdateFlag)
	| WebCore::Document::recalcStyle(WebCore::Node::StyleChange)
	| WebCore::Element::recalcStyle(WebCore::Node::StyleChange)
	| WebCore::Document::styleSelector()
	| WebCore::Document::createStyleSelector()
	| WebCore::CSSStyleSelector::CSSStyleSelector(WebCore::Document*, WebCore::StyleSheetList*, WebCore::CSSStyleSheet*, WebCore::CSSStyleSheet*, WTF::Vector<WTF::RefPtr<WebCore::CSSStyleSheet>, 0ul> const*, bool, bool)
	| WebCore::CSSRuleSet::addRulesFromSheet(WebCore::CSSStyleSheet*, WebCore::MediaQueryEvaluator const&, WebCore::CSSStyleSelector*)
	| WebCore::CSSRuleSet::addStyleRule(WebCore::CSSStyleRule*)
	| WebCore::CSSRuleSet::addRule(WebCore::CSSStyleRule*, WebCore::CSSSelector*)
	| WebCore::CSSRuleSet::addToRuleSet(WTF::AtomicStringImpl*, WTF::HashMap<WTF::AtomicStringImpl*, WebCore::CSSRuleDataList*, WTF::PtrHash<WTF::AtomicStringImpl*>, WTF::HashTraits<WTF::AtomicStringImpl*>, WTF::HashTraits<WebCore::CSSRuleDataList*> >&, WebCore::CSSStyleRule*, WebCore::CSSSelector*)
	| WebCore::CSSRuleDataList::CSSRuleDataList(unsigned int, WebCore::CSSStyleRule*, WebCore::CSSSelector*)
	| WTF::fastMalloc(unsigned long)

[Simon Fraser (smfr)]

<rdar://problem/8911607>

[Simon Fraser (smfr)]

Created attachment 80021 [details]
Patch

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/76573