WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
53058
Reset the page scale factor on standard frame loads
https://bugs.webkit.org/show_bug.cgi?id=53058
Summary
Reset the page scale factor on standard frame loads
Anders Carlsson
Reported
2011-01-24 18:23:51 PST
Reset the page scale factor on standard frame loads
Attachments
Patch
(5.78 KB, patch)
2011-01-24 18:26 PST
,
Anders Carlsson
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2011-01-24 18:26:19 PST
Created
attachment 80005
[details]
Patch
mitz
Comment 2
2011-01-24 18:30:03 PST
Comment on
attachment 80005
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=80005&action=review
> Source/WebKit2/UIProcess/WebPageProxy.h:263 > + void viewScaleFactorDidChange(double scaleFactor);
Can omit “scaleFactor”
> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:438 > + newPageScaleFactor = 1.0;
Should omit “.0”. Also, no need to fetch the value if the above condition holds, only to have it overwritten by 1.
Anders Carlsson
Comment 3
2011-01-24 18:38:18 PST
Committed
r76561
: <
http://trac.webkit.org/changeset/76561
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug