Bug 53058 - Reset the page scale factor on standard frame loads
Summary: Reset the page scale factor on standard frame loads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-24 18:23 PST by Anders Carlsson
Modified: 2011-01-24 18:38 PST (History)
0 users

See Also:

Attachments
Patch (5.78 KB, patch)
2011-01-24 18:26 PST, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-01-24 18:23:51 PST 
Reset the page scale factor on standard frame loads
Comment 1 Anders Carlsson 2011-01-24 18:26:19 PST 
Created attachment 80005 [details]
Patch
Comment 2 mitz 2011-01-24 18:30:03 PST 
Comment on attachment 80005 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80005&action=review

> Source/WebKit2/UIProcess/WebPageProxy.h:263
> +    void viewScaleFactorDidChange(double scaleFactor);

Can omit “scaleFactor”

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:438
> +        newPageScaleFactor = 1.0;

Should omit “.0”. Also, no need to fetch the value if the above condition holds, only to have it overwritten by 1.
Comment 3 Anders Carlsson 2011-01-24 18:38:18 PST 
Committed r76561: <http://trac.webkit.org/changeset/76561>