Bug 53050 - Remove RenderSlider::inDragMode and use SliderThumbElement::inDragMode instead.
Summary: Remove RenderSlider::inDragMode and use SliderThumbElement::inDragMode instead.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 44907
  Show dependency treegraph
 
Reported: 2011-01-24 16:34 PST by Dimitri Glazkov (Google)
Modified: 2011-04-13 10:04 PDT (History)
1 user (show)

See Also:


Attachments
Patch (9.96 KB, patch)
2011-01-24 16:36 PST, Dimitri Glazkov (Google)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-01-24 16:34:29 PST
Remove RenderSlider::inDragMode and use SliderThumbElement::inDragMode instead.
Comment 1 Dimitri Glazkov (Google) 2011-01-24 16:36:54 PST
Created attachment 79989 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-01-24 16:38:23 PST
Just cleaning stuff up after the move.
Comment 3 Darin Adler 2011-01-25 09:06:31 PST
Comment on attachment 79989 [details]
Patch

Seems strange to have all this code that is render tree oriented have to go back to the DOM tree for one thing and not the rest. The RenderThemeWin code especially stands out, with all those renderer checks mixed in with one DOM check.
Comment 4 Dimitri Glazkov (Google) 2011-01-25 14:19:08 PST
(In reply to comment #3)
> (From update of attachment 79989 [details])
> Seems strange to have all this code that is render tree oriented have to go back to the DOM tree for one thing and not the rest. The RenderThemeWin code especially stands out, with all those renderer checks mixed in with one DOM check.

I am on the fence with this patch. Perhaps turn this into a helper function on RenderSliderThumb object?
Comment 5 Dimitri Glazkov (Google) 2011-04-13 10:04:24 PDT
I decided that this patch isn't useful.