When the :before and/or :after pseudo-elements of an element are enclosed in an anonymous renderer, inside their parent renderer, they are not found by the layoutTestController.counterValueForElementById function.
Have patch ready, waiting for my patch to 53024 to land as it depends on that.
Created attachment 80660 [details] Proposed Patch This is my proposed patch. Waiting for my patch to 53024 to be landed before I submit this for review and commit (or else it won't build).
Created attachment 80767 [details] Proposed Patch
Comment on attachment 80767 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80767&action=review Feel free to have another committer change commit-queue from - to + if you decide you don’t want to make my suggested minor tweaks. > Source/WebCore/rendering/RenderTreeAsText.cpp:773 > + // The counter renderers should be children of > + // :before or :after pseudo-elements. No reason to break this comment into two lines. > Source/WebCore/rendering/RenderTreeAsText.cpp:780 > + RenderObject* pseudoElement = renderer->beforePseudoElementRenderer(); > + if (pseudoElement) > + writeCounterValuesFromChildren(stream, pseudoElement, isFirstCounter); > + pseudoElement = renderer->afterPseudoElementRenderer(); > + if (pseudoElement) > + writeCounterValuesFromChildren(stream, pseudoElement, isFirstCounter); I suggest putting the local variable definitions into the if statements.
Created attachment 80786 [details] Proposed Patch. Addressed darin's concerns
Comment on attachment 80786 [details] Proposed Patch. Addressed darin's concerns r=me
Comment on attachment 80786 [details] Proposed Patch. Addressed darin's concerns Clearing flags on attachment: 80786 Committed r77273: <http://trac.webkit.org/changeset/77273>
All reviewed patches have been landed. Closing bug.