Bug 53030 - [Qt] Unskip html5lib/runner.html
Summary: [Qt] Unskip html5lib/runner.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on: 51379
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-24 11:32 PST by Robert Hogan
Modified: 2011-10-25 02:34 PDT (History)
2 users (show)

See Also:


Attachments
Remove from Skipped list. (1.13 KB, patch)
2011-10-24 08:31 PDT, Zoltan Arvai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2011-01-24 11:32:55 PST
when bug 51379 is resolved
Comment 1 Dominic Cooney 2011-02-06 18:10:10 PST
After 51379 keygen no longer fails, but entity test fails:

--- /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/html5lib/runner-expected.txt	2011-02-06 17:47:15.689742095 -0800
+++ /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/html5lib/runner-actual.txt	2011-02-06 17:47:15.689742095 -0800
@@ -315,8 +315,35 @@
 
 resources/html5test-com.dat: PASS
 
-resources/entities01.dat: PASS
+resources/entities01.dat:
+63
+65
 
+Test 63 of 67 in resources/entities01.dat failed. Input:
+FOOZOO
+Got:
+| <html>
+|   <head>
+|   <body>
+|     "FOO?ZOO"
+Expected:
+| <html>
+|   <head>
+|   <body>
+|     "FOO�ZOO"
+
+Test 65 of 67 in resources/entities01.dat failed. Input:
+FOO&#x10FFFF;ZOO
+Got:
+| <html>
+|   <head>
+|   <body>
+|     "FOO?ZOO"
+Expected:
+| <html>
+|   <head>
+|   <body>
+|     "FOO�ZOO"
 resources/entities02.dat: PASS
 
 resources/comments01.dat: PASS
Comment 2 Robert Hogan 2011-02-13 04:58:49 PST
Oh God, more Qt UTF8-related foo.
Comment 3 Robert Hogan 2011-02-13 05:28:07 PST
I don't get this locally - linked against both Qt 7.1 stable trunk and Qt 6.X.
Comment 4 Zoltan Arvai 2011-10-24 08:31:47 PDT
Created attachment 112191 [details]
Remove from Skipped list.

Test passes with current revisions. (Qt 4.8.0-rc1)
Comment 5 Csaba Osztrogonác 2011-10-25 02:34:52 PDT
Comment on attachment 112191 [details]
Remove from Skipped list.

Clearing flags on attachment: 112191

Committed r98329: <http://trac.webkit.org/changeset/98329>
Comment 6 Csaba Osztrogonác 2011-10-25 02:34:59 PDT
All reviewed patches have been landed.  Closing bug.