VERIFIED FIXED Bug 5303
TextInputController should support attributed strings 
https://bugs.webkit.org/show_bug.cgi?id=5303
Summary TextInputController should support attributed strings
Alexey Proskuryakov
Reported 2005-10-09 02:45:03 PDT
Attachments
proposed patch (10.40 KB, patch)
2005-10-09 02:45 PDT, Alexey Proskuryakov 		mjs: review-
DetailsFormatted DiffDiff
Patch with a corrected test case (10.45 KB, patch)
2005-10-14 13:10 PDT, Alexey Proskuryakov 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2005-10-09 02:45:28 PDT
Created attachment 4264 [details] proposed patch
Maciej Stachowiak
Comment 2 2005-10-13 23:26:35 PDT
It would be preferrable to document.write() the various test outputs instead of alert()ing them, because alert can have timing issues in webkit tests sometimes, and lead to tests that periodically fail. r- for that, but the substance of the patch is fine I suppose. Woudl be better if we actually had any support for attributedSubstringInRange: in WebHTMLView.
Alexey Proskuryakov
Comment 3 2005-10-14 13:10:42 PDT
Created attachment 4362 [details] Patch with a corrected test case Yes, implementing [WebHTMLView attributedSubstringInRange] is a work in progress (bug 4680), and I expect that having such a testing facility will help to move it forward...
Maciej Stachowiak
Comment 4 2005-10-18 00:46:28 PDT
Comment on attachment 4362 [details] Patch with a corrected test case r=me
Note You need to log in before you can comment on or make changes to this bug.