Bug 53029 - WebKit2: LayoutTests: The UNIMPLEMENTED warnings in TextCheckerWin should be disabled
Summary: WebKit2: LayoutTests: The UNIMPLEMENTED warnings in TextCheckerWin should be ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Windows 7
: P2 Normal
Assignee: Jessie Berlin
URL:
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-01-24 11:32 PST by Jessie Berlin
Modified: 2011-01-24 13:03 PST (History)
4 users (show)

See Also:

Attachments
Patch (deleted)
2011-01-24 11:37 PST, Jessie Berlin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2011-01-24 11:32:20 PST 
They are showing up in the output of a lot of layout tests (e.g. plugins/access-after-page-destroyed.html), particularly due to the call in

const TextCheckerState& TextChecker::state()
{
    notImplemented();

    return textCheckerState;
}

We should disable the UNIMPLEMENTED warnings in TextCheckerWin.cpp.
Comment 1 Anders Carlsson 2011-01-24 11:35:57 PST 
This can be done with

#define DISABLE_NOT_IMPLEMENTED_WARNINGS 1
Comment 2 Jessie Berlin 2011-01-24 11:37:08 PST 
Created attachment 79946 [details]
Patch
Comment 3 Jessie Berlin 2011-01-24 13:03:34 PST 
Comment on attachment 79946 [details]
Patch

Committed in r76543
http://trac.webkit.org/changeset/76543