WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
53018
Web Inspector: Incorrect on-hover evaluation of a variable named 'profile'
https://bugs.webkit.org/show_bug.cgi?id=53018
Summary
Web Inspector: Incorrect on-hover evaluation of a variable named 'profile'
Mikhail Naganov
Reported
2011-01-24 09:02:57 PST
Created
attachment 79932
[details]
sample page If I have a local variable named 'profile', it's being incorrectly evaluated as 'function profile' in the yellow on-hover popup appearing in Debugger. Reproducible both in Safari and Chrome.
Attachments
sample page
(291 bytes, text/html)
2011-01-24 09:02 PST
,
Mikhail Naganov
no flags
Details
Safari screenshot
(111.26 KB, image/png)
2011-01-24 09:03 PST
,
Mikhail Naganov
no flags
Details
[PATCH] Proposed change.
(26.08 KB, patch)
2011-01-25 08:41 PST
,
Pavel Feldman
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mikhail Naganov
Comment 1
2011-01-24 09:03:41 PST
Created
attachment 79933
[details]
Safari screenshot
Pavel Feldman
Comment 2
2011-01-25 08:41:43 PST
Created
attachment 80067
[details]
[PATCH] Proposed change.
Yury Semikhatsky
Comment 3
2011-01-25 23:56:32 PST
Comment on
attachment 80067
[details]
[PATCH] Proposed change. View in context:
https://bugs.webkit.org/attachment.cgi?id=80067&action=review
I'd really appreciate if you wrote a test for this fix.
> Source/WebCore/inspector/front-end/ScriptsPanel.js:328 > var self = this;
Can you bind the function below to "this" object instead like we do with other callbacks.
Pavel Feldman
Comment 4
2011-01-26 02:20:24 PST
Committed
r76680
: <
http://trac.webkit.org/changeset/76680
>
WebKit Review Bot
Comment 5
2011-01-26 03:00:14 PST
http://trac.webkit.org/changeset/76680
might have broken Qt Linux Release The following tests are not passing: http/tests/inspector/console-resource-errors.html http/tests/inspector/extensions-headers.html http/tests/inspector/extensions-resources-redirect.html inspector/console-command-clear.html inspector/console-dir-global.html inspector/console-dir.html inspector/console-format.html inspector/console-object-constructor-name.html inspector/console-uncaught-exception-in-eval.html inspector/console-uncaught-exception.html inspector/cookie-parser.html inspector/cpu-profiler-profiling.html inspector/debugger-autocontinue-on-syntax-error.html inspector/debugger-scripts.html inspector/debugger-suspend-active-dom-objects.html inspector/elements-delete-inline-style.html inspector/extensions-api.html inspector/extensions-audits-api.html inspector/extensions-audits.html inspector/extensions-eval.html inspector/extensions-events.html inspector/extensions-resources.html inspector/report-API-errors.html inspector/report-protocol-errors.html inspector/storage-panel-dom-storage.html inspector/styles-disable-then-change.html inspector/styles-url-linkify.html
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug