Bug 53015 - Remove obsolete public/API methods in chromium port
Summary: Remove obsolete public/API methods in chromium port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-24 08:34 PST by Satish Sampath
Modified: 2011-01-24 09:36 PST (History)
1 user (show)

See Also:


Attachments
Patch (975 bytes, patch)
2011-01-24 08:38 PST, Satish Sampath
no flags Details | Formatted Diff | Diff
Patch (1.64 KB, patch)
2011-01-24 08:55 PST, Satish Sampath
ossy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Satish Sampath 2011-01-24 08:34:53 PST
In http://trac.webkit.org/changeset/76128 the speech input API was changed to include additional parameters. Now that chromium has picked up this change we no longer need the old style wrappers which were left in place for a clean transition.
Comment 1 Satish Sampath 2011-01-24 08:38:48 PST
Created attachment 79926 [details]
Patch
Comment 2 Satish Sampath 2011-01-24 08:55:56 PST
Created attachment 79929 [details]
Patch
Comment 3 Csaba Osztrogonác 2011-01-24 08:59:15 PST
Comment on attachment 79929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79929&action=review

Otherwise LGTM, rs=me.

> Source/WebKit/chromium/ChangeLog:5
> +        Remove obsolete public/API methods in chromium port

s/methods/method
Comment 4 Satish Sampath 2011-01-24 09:36:41 PST
Committed r76526: <http://trac.webkit.org/changeset/76526>