IndexedDatabase methods should not take arguments of type OptionsObject
Created attachment 79925 [details] Patch
Looks good as far as I can tell.
Attachment 79925 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7531301
Created attachment 79934 [details] Patch
Comment on attachment 79934 [details] Patch My only complaint is that we're adding yet another converter to V8Binding.cpp, but I don't think that's avoidable.
Comment on attachment 79934 [details] Patch > Source/WebCore/storage/IDBDatabase.cpp:113 > + if (timeout > std::numeric_limits<unsigned long>::max()) It still feels fishy. It seems to me this condition can never be true?
Attachment 79925 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7546312
Comment on attachment 79934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79934&action=review LGTM > Source/WebCore/bindings/v8/V8Binding.h:35 > +#include "DOMStringList.h" Just forward declare here. >> Source/WebCore/storage/IDBDatabase.cpp:113 >> + if (timeout > std::numeric_limits<unsigned long>::max()) > > It still feels fishy. It seems to me this condition can never be true? It really doesn't matter either way...
(In reply to comment #8) > (From update of attachment 79934 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79934&action=review > > LGTM > > > Source/WebCore/bindings/v8/V8Binding.h:35 > > +#include "DOMStringList.h" > > Just forward declare here. > Done. > >> Source/WebCore/storage/IDBDatabase.cpp:113 > >> + if (timeout > std::numeric_limits<unsigned long>::max()) > > > > It still feels fishy. It seems to me this condition can never be true? > > It really doesn't matter either way... I will remove that check then and land. Thanks all for the reviews!
Committed r76531: <http://trac.webkit.org/changeset/76531>