RESOLVED FIXED 52990
[EFL] Add an API to get proxy address 
https://bugs.webkit.org/show_bug.cgi?id=52990
Summary [EFL] Add an API to get proxy address
Gyuyoung Kim
Reported 2011-01-23 21:35:08 PST
I add an API to get proxy address. For now, this API only can return proxy on soup network backend. I think we need sometimes to know existed proxy address.
Attachments
Patch (2.11 KB, patch)
2011-01-23 21:36 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (2.10 KB, patch)
2011-01-23 21:55 PST, Gyuyoung Kim 		tonikitoo: review+
gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
Patch (2.13 KB, patch)
2011-01-24 21:13 PST, Gyuyoung Kim 		tonikitoo: review+
DetailsFormatted DiffDiff
Patch (2.21 KB, patch)
2011-02-01 01:58 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2011-01-23 21:36:44 PST
Created attachment 79890 [details] Patch
WebKit Review Bot
Comment 2 2011-01-23 21:39:17 PST
Attachment 79890 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ewk/ewk_settings.cpp:301: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gyuyoung Kim
Comment 3 2011-01-23 21:55:22 PST
Created attachment 79892 [details] Patch
Antonio Gomes
Comment 4 2011-01-24 06:35:32 PST
Comment on attachment 79892 [details] Patch Please someone from EFL team double check the documentation.
Gyuyoung Kim
Comment 5 2011-01-24 21:13:41 PST
Created attachment 80012 [details] Patch I modify the comment for this API.
Gyuyoung Kim
Comment 6 2011-01-25 13:39:24 PST
Hello Lucas, I modify the comment new API. Could you please check if there is problem ?
Gyuyoung Kim
Comment 7 2011-01-31 00:17:53 PST
Hello Antonio, There was no response from profusion guys. IMO, I'm enough to fix the comment. Could you please review this patch again ?
Antonio Gomes
Comment 8 2011-01-31 06:32:54 PST
Comment on attachment 80012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80012&action=review Next time you can just reupload it with "Reviewed by Antonio Gomes", and set cq+ yourself ;) > Source/WebKit/efl/ChangeLog:9 > + which is set up by ewk_settings_proxy_uri_set(). I would also mention that it only implements the API for libsoup network backend. > Source/WebKit/efl/ewk/ewk_settings.cpp:294 > + * Gets the proxy URI from network backend. from THE network backend.
Gyuyoung Kim
Comment 9 2011-02-01 01:58:27 PST
Created attachment 80730 [details] Patch
WebKit Commit Bot
Comment 10 2011-02-01 04:42:58 PST
Comment on attachment 80730 [details] Patch Clearing flags on attachment: 80730 Committed r77243: <http://trac.webkit.org/changeset/77243>
Note You need to log in before you can comment on or make changes to this bug.