Bug 52971 - ASSERT running run-webkit-tests --threaded
Summary: ASSERT running run-webkit-tests --threaded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-22 20:40 PST by Geoffrey Garen
Modified: 2011-01-24 05:11 PST (History)
1 user (show)

See Also:


Attachments
Patch (8.42 KB, patch)
2011-01-22 20:43 PST, Geoffrey Garen
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-01-22 20:40:32 PST
ASSERT running run-webkit-tests --threaded
Comment 1 Geoffrey Garen 2011-01-22 20:43:46 PST
Created attachment 79862 [details]
Patch
Comment 2 mitz 2011-01-22 20:54:31 PST
Comment on attachment 79862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79862&action=review

> Source/JavaScriptCore/runtime/ConservativeSet.h:46
> +    static const size_t inlineCapacity = 128;

The increased inline capacity might be worth mentioning in the change log.

> Source/JavaScriptCore/runtime/ConservativeSet.h:70
> +    if (m_set == m_inlineSet)
> +        return;
> +    OSAllocator::decommitAndRelease(m_set, m_capacity * sizeof(JSCell*));

I know how to turn this into a 2-line function.
Comment 3 Geoffrey Garen 2011-01-22 21:03:45 PST
Committed r76457: <http://trac.webkit.org/changeset/76457>
Comment 4 Csaba Osztrogonác 2011-01-24 05:11:58 PST
(In reply to comment #3)
> Committed r76457: <http://trac.webkit.org/changeset/76457>

trunk/runtime directory was committed accidentally,it 
was removed by http://trac.webkit.org/changeset/76508