Bug 52969 - Fix FFTFrameStub to compile properly
Summary: Fix FFTFrameStub to compile properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-22 14:50 PST by Chris Rogers
Modified: 2011-01-22 16:34 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.18 KB, patch)
2011-01-22 14:57 PST, Chris Rogers
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-01-22 14:50:39 PST
Fix FFTFrameStub to compile properly
Comment 1 Chris Rogers 2011-01-22 14:57:49 PST
Created attachment 79859 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-01-22 15:01:21 PST
Comment on attachment 79859 [details]
Patch

What was the build error?  I don't understand why commenting things out like this is the right fix.
Comment 3 Chris Rogers 2011-01-22 15:05:27 PST
the build error is that it will not compile on Linux because the log2() function is not known.  Since this is simply a stub implementation there's no need to initialize these variables to other than zero.
Comment 4 Daniel Bates 2011-01-22 16:31:07 PST
Comment on attachment 79859 [details]
Patch

Will land by hand as requested by Chris Rogers.
Comment 5 Daniel Bates 2011-01-22 16:34:35 PST
Committed r76456: <http://trac.webkit.org/changeset/76456>