Bug 52960 - REGRESSION: Vertical line metrics incorrect
Summary: REGRESSION: Vertical line metrics incorrect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 51456
  Show dependency treegraph
 
Reported: 2011-01-22 05:31 PST by Nikolas Zimmermann
Modified: 2011-01-22 05:46 PST (History)
1 user (show)

See Also:


Attachments
Patch (13.09 KB, patch)
2011-01-22 05:36 PST, Nikolas Zimmermann
krit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2011-01-22 05:31:58 PST
After landing the FontMetrics abstraction from bug 51456, vertical line metrics are incorrect.
There's a hack in SimpleFontDataMac.mm that modifies lineGap/descent for a certain vertical font. That hack now influences the lineSpacing, where it shouldn't.

Attaching a patch soon, to restore the old behaviour.
Comment 1 Nikolas Zimmermann 2011-01-22 05:36:54 PST
Created attachment 79844 [details]
Patch
Comment 2 Dirk Schulze 2011-01-22 05:39:41 PST
Comment on attachment 79844 [details]
Patch

r=me
Comment 3 Nikolas Zimmermann 2011-01-22 05:46:57 PST
Landed fix in r76445. Let's see..