Bug 52956 - [Qt] Support layoutTestController.addURLToRedirect()
Summary: [Qt] Support layoutTestController.addURLToRedirect()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Robert Hogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-22 04:25 PST by Robert Hogan
Modified: 2011-01-22 09:28 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.71 KB, patch)
2011-01-22 04:27 PST, Robert Hogan 		no flags Details | Formatted Diff | Diff
Patch (7.76 KB, patch)
2011-01-22 06:36 PST, Robert Hogan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2011-01-22 04:25:42 PST 
[Qt] Support layoutTestController.addURLToRedirect()
Comment 1 Robert Hogan 2011-01-22 04:27:04 PST 
Created attachment 79842 [details]
Patch
Comment 2 Andreas Kling 2011-01-22 05:01:23 PST 
Comment on attachment 79842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79842&action=review

r=me, one comment.

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1027
> +    QString url = newRequest.url().string();
> +    if (URLsToRedirect.contains(url))
> +        newRequest.setURL(QUrl(URLsToRedirect[url]));

Let's only do this if QWebPagePrivate::drtRun is true.
Comment 3 Robert Hogan 2011-01-22 06:36:36 PST 
Created attachment 79845 [details]
Patch
Comment 4 Robert Hogan 2011-01-22 09:28:12 PST 
Committed r76451: <http://trac.webkit.org/changeset/76451>