Bug 52951 - WebKit2 generates a bad PDF for cross process messaging
Summary: WebKit2 generates a bad PDF for cross process messaging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Printing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-21 23:43 PST by Alexey Proskuryakov
Modified: 2011-01-22 00:22 PST (History)
3 users (show)

See Also:

Attachments
proposed fix (2.74 KB, patch)
2011-01-21 23:46 PST, Alexey Proskuryakov 		mitz: review+
Details | Formatted Diff | Diff
patch for landing (2.49 KB, patch)
2011-01-21 23:56 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-01-21 23:43:26 PST 
It's offset down by frame.height - page.height, so most pages draw outside PDF media box. While the error in web process is compensated by a symmetrical error in UI process, nothing guarantees that CGPDFContext won't discard the data outside media box.
Comment 1 Alexey Proskuryakov 2011-01-21 23:46:17 PST 
Created attachment 79832 [details]
proposed fix
Comment 2 mitz 2011-01-21 23:49:08 PST 
Comment on attachment 79832 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=79832&action=review

> Source/WebCore/ChangeLog:21
> +2011-01-21  Alexey Proskuryakov  <ap@apple.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Need a short description and bug URL (OOPS!)
> +
> +        No new tests. (OOPS!)
> +
> +        * page/PrintContext.cpp:
> +        (WebCore::PrintContext::spoolRect):
> +

Redundant change log entry.
Comment 3 Alexey Proskuryakov 2011-01-21 23:56:11 PST 
Created attachment 79833 [details]
patch for landing

Oops.
Comment 4 WebKit Commit Bot 2011-01-22 00:22:09 PST 
Comment on attachment 79833 [details]
patch for landing

Clearing flags on attachment: 79833

Committed r76433: <http://trac.webkit.org/changeset/76433>
Comment 5 WebKit Commit Bot 2011-01-22 00:22:14 PST 
All reviewed patches have been landed.  Closing bug.