[chromium] turn off gyp circular dependency checking and roll chromium deps
Created attachment 79805 [details] Patch
Turning off gyp circular dependencies is needed to get us to roll past chromium@72103.
Are you sure we don't have the circular dependency on mac as well? Which part of the cycle exists only on mac? Would it be better to just fix the dependency issue?
(In reply to comment #3) > Are you sure we don't have the circular dependency on mac as well? Which part of the cycle exists only on mac? exists only on !mac, that is
(In reply to comment #4) > (In reply to comment #3) > > Are you sure we don't have the circular dependency on mac as well? Which part of the cycle exists only on mac? > > exists only on !mac, that is Yes, if it existed on mac, gyp_chromium would have failed. The dependency is here in a *nix only section: http://git.chromium.org/gitweb/?p=chromium.git;a=blob;f=skia/skia.gyp;h=4c51e8aed406af1293e4168899f65d4755fdc815;hb=HEAD#l714 I've notified the original authors (thakis and reed) of the circular dependency and I think they're going to fix it. They'll have to fix it if we need this on mac.
Here's the same logic in gyp_chromium that would fail for the same reason: http://git.chromium.org/gitweb/?p=chromium.git;a=blob;f=build/gyp_chromium;h=21717705f30340011f5128ff3f7439955812d8ea;hb=HEAD#l107
Comment on attachment 79805 [details] Patch T.T
Committed r76527: <http://trac.webkit.org/changeset/76527>