nrwt: handle broken pipe errors from DRT more cleanly
Created attachment 79799 [details] Patch
Comment on attachment 79799 [details] Patch Looks reasonable. Seems we should have a test though.
I thought about this a fair amount before uploading the patch, and it's not clear to me how to usefully test this. To do so either requires spawning off a process that crashes at exactly the right point (since most of the time I'll pick up the crash during the read loop) or mocking out several layers of calls, which seems overly contrived and kind of pointless. I'm open to suggestions, though; any ideas on how you would test it?
Comment on attachment 79799 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79799&action=review > Tools/Scripts/webkitpy/layout_tests/port/server_process.py:119 > + self._proc.stdin.write(input) Oh, I had assumed one would just mock the multiple layers. I don't know how much other mocking has already been done for testing this class.
Created attachment 81015 [details] add unit test for broken pipes
Committed r77592: <http://trac.webkit.org/changeset/77592>