Add segmentation test for range.expand.
Created attachment 79798 [details] layout test
Comment on attachment 79798 [details] layout test This is going to break other platforms. We should either be adding chromium specific test or should be adding a new test when Xiaomei lands a patch to upstream fixes.
Just some clarification: ICU bug to upstream Chrome's CJK segmentation patch is http://bugs.icu-project.org/trac/ticket/2229 Even if that's added to the ICU trunk today, it'll be a year or more before Apple picks it up in next version of Mac OS X. Moreover, there are webkit ports that do not use ICU (e.g. Qt, GTK). So fixing the above ICU bug wouldn't help them.
BTW, shouldn't the test be more 'interesting' (dealing with non-trivial but fairly clear-cut cases)? 国务院公布《国有土地) 国务院 公布 ( 国有 土地 )
Created attachment 79966 [details] layout test
Created attachment 79973 [details] layout test
Comment on attachment 79973 [details] layout test View in context: https://bugs.webkit.org/attachment.cgi?id=79973&action=review > LayoutTests/platform/chromium/fast/text/international/cjk-segmentation-expected.txt:3 > +Test Chinese Segmentation. > + > + We should print out PASS at the end or otherwise, or otherwise it's hard to tell if the test really passed or not.
Comment on attachment 79973 [details] layout test View in context: https://bugs.webkit.org/attachment.cgi?id=79973&action=review > LayoutTests/fast/text/international/cjk-segmentation.html:2 > +<html> > +<head> Missing DOCTYPE here: <!DOCTYPE html> > LayoutTests/fast/text/international/cjk-segmentation.html:3 > +<META HTTP-EQUIV="CONTENT-TYPE" CONTENT="text/html; charset=UTF-8"> We probably want to use lowercases for tag and attribute names for the consistency. > LayoutTests/fast/text/international/cjk-segmentation.html:21 > + } Maybe print PASS here?
Created attachment 79976 [details] layout test
Comment on attachment 79976 [details] layout test View in context: https://bugs.webkit.org/attachment.cgi?id=79976&action=review > LayoutTests/fast/text/international/cjk-segmentation.html:5 > +<title>Test for CJK segmentation.</title> Nit: Don't put period in the title. > LayoutTests/fast/text/international/cjk-segmentation.html:50 > + if (pass == true) { > + log("ALL PASS"); > + } Nit: no { } around a single line statement.
Committed r76548: <http://trac.webkit.org/changeset/76548>
http://trac.webkit.org/changeset/76548 might have broken Qt Linux Release The following tests are not passing: fast/text/international/cjk-segmentation.html
This test is failing on Chromium mac port.
(In reply to comment #3) > Just some clarification: > > ICU bug to upstream Chrome's CJK segmentation patch is http://bugs.icu-project.org/trac/ticket/2229 > > Even if that's added to the ICU trunk today, it'll be a year or more before Apple picks it up in next version of Mac OS X. No patch has ever been posted to that ICU bug. Could you at least post a WIP patch so someone else can work on it if you don't have time?